Conversation
Remove the stale native tag and build-from-source install argument. Current thread-sleep releases are implemented in JavaScript and no longer contain a native build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1896c431-0032-423c-afbe-3133ce92cec7
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 29 29
Lines 2213 2213
=======================================
Hits 2129 2129
Misses 84 84 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the stale native-build metadata from the
thread-sleeplookup entry.Why this is needed
CITGM currently installs the fixture with:
--build-from-sourcehistorically forwarded configuration to native installers. npm 12 rejects unknown CLI configuration flags, so the command now fails withEUNKNOWNCONFIGbefore installation or tests begin.Current
thread-sleep@2.2.0releases are implemented entirely in JavaScript. The selected source contains nobinding.gyp, native dependency, binary configuration, or install script. It executes a child Node.js process and usessetTimeoutto provide synchronous sleeping behavior.The source-build override and
nativetag are therefore leftovers from thread-sleep's older native implementation. Replacing the CLI flag with an environment variable would preserve behavior that the current fixture no longer has. This change removes both stale fields and lets CITGM perform a normal install before running the existing timing tests.The fixture remains marked flaky because its timing assertions can still vary under load. This change does not alter that independent disposition.
Addresses npm/cli#10023.
Validation
./node_modules/.bin/eslint --cache./node_modules/.bin/prettier --check lib/lookup.json./node_modules/.bin/tap run test/test-lookup.js test/test-create-options.jsjq empty lib/lookup.jsongit diff --check