Skip to content

lookup: unskip eslint - #1162

Draft
abhayagarwal-dev wants to merge 2 commits into
nodejs:mainfrom
abhayagarwal-dev:unskip-eslint
Draft

abhayagarwal-dev wants to merge 2 commits into
nodejs:mainfrom
abhayagarwal-dev:unskip-eslint

Conversation

@abhayagarwal-dev

@abhayagarwal-dev abhayagarwal-dev commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Removes "skip": true for eslint. The skip was added in 2019 because eslint required libX11 for headless Chrome testing. Modern eslint no longer uses headless Chrome so the dependency is gone.

Also removed the flaky entry and the now-outdated comment.

Verified on s390x with Node.js v22.23.2:

citgm eslint
info: starting            | eslint              
info: lookup              | eslint              
info: lookup-found        | eslint              
info: eslint lookup-replace| https://github.com/eslint/eslint/archive/a438ec39512c3381f4785a1f3058982ce9845970.tar.gz
info: eslint npm:         | Downloading project: https://github.com/eslint/eslint/archive/a438ec39512c3381f4785a1f3058982ce9845970.tar.gz
info: eslint npm:         | Project downloaded a438ec39512c3381f4785a1f3058982ce9845970.tar.gz
info: eslint npm:         | npm install started 
info: eslint npm:         | npm install successfully completed
info: eslint npm:         | test suite started  
info: passing module(s)   |                     
info: module name:        | eslint              
info: version:            | 10.12.0             
info: done                | The smoke test has passed.
info: duration            | test duration: 125069ms
Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (8914dd0) to head (bc3135c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   96.20%   96.20%           
=======================================
  Files          29       29           
  Lines        2213     2213           
=======================================
  Hits         2129     2129           
  Misses         84       84           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MikeMcC399

Copy link
Copy Markdown
Contributor

Before re-enabling, I would check with @nzakas about the maintainers for https://github.com/eslint/eslint listed in

citgm/lib/lookup.json

Lines 155 to 162 in 8914dd0

"eslint": {
"prefix": "v",
"flaky": ["s390", "ubuntu"],
"skip": true,
"expectFail": "fips",
"maintainers": ["nzakas", "mysticatea", "not-an-aardvark"],
"comment": "Skipped because libX11 is required for headless Chrome"
},

https://github.com/nzakas - major player for ESLint and member of ESLint Technical Steering Committee
https://github.com/mysticatea - last PR was in 2021
https://github.com/not-an-aardvark - last PR was in 2019

@MikeMcC399

This comment was marked as resolved.

@abhayagarwal-dev

Copy link
Copy Markdown
Contributor Author

Edit: The PR has been changed, so now the PR description no longer matches the changes.

I have updated the pr descryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants