Skip to content

chore: add jest to lookup #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 7 commits into from
Mar 7, 2021
Merged

chore: add jest to lookup #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f7ac2fc
chore: add jest to lookup
SimenB May 10, 2019
128fee2
bump timeout even more
SimenB Oct 20, 2020
b79c5c6
fix install/build script
SimenB Oct 20, 2020
a639e47
skip node 10
SimenB Oct 20, 2020
bf6849e
skip on darwin and lower timeout again
SimenB Oct 21, 2020
568641e
whoops, not that much
SimenB Oct 21, 2020
bfaba7a
skip windows
SimenB Mar 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/grab-project.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ async function grabProject(context) {
}

return new Promise((resolve, reject) => {
const packageManager =
context.options.yarn || context.module.useYarn ? 'yarn' : 'npm';
let packageName = context.module.raw;
if (context.module.type === 'directory') {
context.module.raw = context.module.name = path.basename(packageName);
Expand All @@ -21,7 +23,7 @@ async function grabProject(context) {
context.emit(
'data',
'info',
`${context.module.name} npm:`,
`${context.module.name} ${packageManager}:`,
`Downloading project: ${packageName}`
);
let options = createOptions(context.path, context);
Expand Down
15 changes: 9 additions & 6 deletions lib/lookup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,6 @@
"maintainers": ["nzakas", "mysticatea", "not-an-aardvark"],
"comment": "Skipped because libX11 is required for headless Chrome"
},
"eslint-plugin-jest": {
"prefix": "v",
"maintainers": "SimenB",
"yarn": true,
"skip": ["aix", "s390x"]
},
"esprima": {
"maintainers": "ariya",
"expectFail": "fips",
Expand Down Expand Up @@ -250,6 +244,15 @@
"prefix": "v",
"maintainers": "juliangruber"
},
"jest": {
"prefix": "v",
"maintainers": ["cpojer", "scotthovestadt", "SimenB", "thymikee", "jeysal"],
"yarn": true,
"scripts": ["build:js", "test-ci-partial"],

@SimenB SimenB Oct 20, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ran tests locally, but seems like CI skipped it? very odd...

image

I'll have to try tomorrow

@SimenB SimenB Oct 21, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea about this - the tests were ran on mac, but timed out.

"envVar": { "CI": true },
"skip": ["aix", "s390x", "ppc", "10.x", "darwin", "win32"],
"timeout": 1800000
},
"jquery": {
"skip": "win32",
"flaky": ["linux", "aix", "darwin"],
Expand Down