Conversation
Type links on section pages kept the URL written for the module page, so `buffer.html#class-buffer` on /fs/callback-api pointed to /fs/buffer and returned a 404. Signed-off-by: Nikhil Kumar Rajak <ryzrr.official@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 90.70% 90.71% +0.01%
==========================================
Files 220 220
Lines 21132 21166 +34
Branches 1991 1996 +5
==========================================
+ Hits 19167 19201 +34
Misses 1958 1958
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
avivkeller
approved these changes
Sep 15, 2026
AugustinMauroy
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type annotation links on section pages are now re-targeted like regular links, so
{Buffer}on/fs/callback-apigoes to/bufferinstead of/fs/buffer(404).Validation
Built the beta docs and link-checked all 617 section pages: 1,687 broken type links now resolve, no other links changed, and a unit test covers it.
Related Issues
Seen live at https://beta.docs.nodejs.org/fs/callback-api#fsaccesspath-mode-callback (click
Buffer).Check List
node --run testand all tests passed.node --run format:check&node --run lint.