Skip to content

docs: move DCO and CoC to CONTRIBUTING - #2643

Merged
MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:contributing-dco-coc
Oct 6, 2026
Merged

MikeMcC399 merged 1 commit into
nodejs:mainfrom
MikeMcC399:contributing-dco-coc

Conversation

@MikeMcC399

@MikeMcC399 MikeMcC399 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Description

Move the following sections:

from the GOVERNANCE document into the CONTRIBUTING document, aligning with the nodejs/node > CONTRIBUTING document as reference model and for better discoverability.

Motivation and Context

The CONTRIBUTING document does not contain information regarding the DCO or the Code of Conduct. This is instead included in the GOVERNANCE document, where it may not be discovered by contributors.

Taking the nodejs/node > CONTRIBUTING document as reference model, this is the place that rules concerning contributing are placed directly, not the GOVERNANCE document.

The nodejs/node-gyp > CONTRIBUTING document also follows this model, as a further example.

Testing Details

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Move the
- Developer's Certificate of Origin 1.1
- Code of Conduct

from the GOVERNANCE document to the CONTRIBUTING document

Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@MikeMcC399
MikeMcC399 marked this pull request as ready for review October 1, 2026 12:02
@MikeMcC399 MikeMcC399 added the docs label Oct 1, 2026
@MikeMcC399 MikeMcC399 self-assigned this Oct 1, 2026

@nschonni nschonni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick skim of https://developercertificate.org/ and I think the text is all up-to-date

Comment thread CONTRIBUTING.md
@MikeMcC399
MikeMcC399 merged commit f4718c1 into nodejs:main Oct 6, 2026
3 checks passed
@MikeMcC399
MikeMcC399 deleted the contributing-dco-coc branch October 6, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants