Repository navigation
Windows GitHub Actions changes required #55929
Description
Version
No response
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
Running vcbuild.bat
How often does it reproduce? Is there a required condition?
Always with VS 17.12.
What is the expected behavior? Why is that the expected behavior?
I expect Node.js to compile.
What do you see instead?
Compilation fails.
Additional information
I've already opened an issue to track this and reported it to Microsoft. In addition to that, I'll open a PR similar to #53863 marking the v17.12 as unsupported so people get informed.
In addition to everything already mentioned we should disable GitHub Actions for Windows: https://github.com/nodejs/node/actions/workflows/build-windows.yml, https://github.com/nodejs/node/actions/workflows/coverage-windows.yml and https://github.com/nodejs/node/actions/workflows/test-windows.yml as they will fail constantly (eg. #55270) because GitHub Runners use VS v17.12 now.
P.S. Maybe we can even remove test-windows.yml as it wasn't run recently?
cc @nodejs/platform-windows @nodejs/build
Activity
richardlau commentedon Nov 20, 2024
Do we know which versions of Node.js are broken with VS v17.12?
For example, both
passed for the v20.18.1 proposal with VS v17.12.
FWIW https://github.com/nodejs/node/actions/workflows/build-windows.yml was removed from
mainby #54662 which was backported to v22.x-staging.test-windows.ymlnever landed -- it was proposed in #50519 (to run tests instead of just building) but closed without merging.targos commentedon Nov 22, 2024
I've disabled the workflows
StefanStojanovic commentedon Nov 25, 2024
Hey, I opened this issue on a day I went OOF, so I didn't have a chance to check the LTS branches. Based on the links you've sent and errors on the latest version, I'd say this was caused by some V8 update after v20. Anyway, I see targos has already disabled them, and the compiler issue has a fix pending release, so hopefully, this will all get resolved quickly.
StefanStojanovic commentedon Dec 9, 2024
Closing this issue based on nodejs/build#3963 (comment)