quic: split headers out from src/quic/stream.{h/cc} - #65863
Open
jasnell wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
jasnell
added
the
quic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65863 +/- ##
==========================================
- Coverage 90.21% 90.17% -0.04%
==========================================
Files 771 771
Lines 264911 264899 -12
Branches 50323 50311 -12
==========================================
- Hits 238977 238880 -97
- Misses 16917 16974 +57
- Partials 9017 9045 +28
🚀 New features to boost your workflow:
|
meixg
approved these changes
Sep 7, 2026
meixg
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
bjohansebas
approved these changes
Sep 7, 2026
As part of the effort to get better separation between the generalized QUIC streams and HTTP/3 streams, separate out header handling from the C++ class. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode
jasnell
force-pushed
the
jasnell/quic-split-headers-out
branch
from
September 7, 2026 13:59
3c257cb to
97e466a
Compare
Collaborator
jasnell
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the effort to get better separation between the generalized QUIC streams and HTTP/3 streams, separate out header handling from the C++ class.
A smaller, incremental alternative approach to part of #63995
/cc @pimterry