Skip to content

perf_hooks: allow RecordableHistogram to record 0 - #66114

Open
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/perf-hooks-histogram-record-zero
Open

perf_hooks: allow RecordableHistogram to record 0#66114
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:jasnell/perf-hooks-histogram-record-zero

Conversation

@jasnell

@jasnell jasnell commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Previously the lowest value accepted was 1.

Includes a small node:bench fix also.

@jasnell jasnell added semver-minor PRs that contain new features and should be released in the next minor version. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. labels Sep 18, 2026
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 18, 2026
jasnell
jasnell commented Sep 18, 2026
View reviewed changes
Comment thread doc/api/perf_hooks.md Outdated
jasnell
jasnell commented Sep 18, 2026
View reviewed changes
Comment thread doc/api/perf_hooks.md Outdated
@jasnell
perf_hooks: allow RecordableHistogram to record 0
48b0a19 
Previously the lowest value accepted was 1.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
lib: fix stream loading bug in node:bench
e8e57a0 
Not all of the stream APIs are correctly loaded until
the `node:stream` module is loaded.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/perf-hooks-histogram-record-zero branch from 8a9ad04 to e8e57a0 Compare September 18, 2026 18:50
@codecov

codecov Bot commented Sep 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.28%. Comparing base (dd5dfb5) to head (e8e57a0).
⚠️ Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
src/histogram.cc 20.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #66114   +/-   ##
=======================================
  Coverage   90.27%   90.28%           
=======================================
  Files         790      790           
  Lines      271651   271648    -3     
  Branches    51842    51839    -3     
=======================================
+ Hits       245228   245244   +16     
+ Misses      16928    16916   -12     
+ Partials     9495     9488    -7
Files with missing lines Coverage Δ
lib/internal/bench_runner/benchmark.js 99.65% <100.00%> (-0.01%) ⬇️
lib/internal/bench_runner/benchmarks_stream.js 99.31% <100.00%> (ø)
lib/internal/histogram.js 97.22% <100.00%> (ø)
src/histogram.cc 85.82% <20.00%> (+0.14%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell
jasnell requested a review from ShogunPanda September 19, 2026 14:23
mcollina
mcollina approved these changes Sep 22, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 22, 2026
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. review wanted PRs that need review. labels Sep 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2026 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77811/ 💛

@jasnell jasnell added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS
@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the perf_hooks module and performance measurement APIs. review wanted PRs that need review. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell @nodejs-github-bot @mcollina