Skip to content

build: port make_temporal_zoneinfo_cpp to GYP - #66183

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:fix-temporal-no-icu
Sep 24, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:fix-temporal-no-icu

Conversation

@aduh95

@aduh95 aduh95 commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Refs: #62676

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Sep 21, 2026
Comment thread tools/v8_gypfiles/v8.gyp Outdated
@Renegade334

Copy link
Copy Markdown
Member

Successful build on linux-x64 / gcc.

> process.config.variables.v8_enable_i18n_support
0
> Temporal.Now.zonedDateTimeISO('Europe/Amsterdam').toString()
'2026-09-24T11:32:53.33537793+02:00[Europe/Amsterdam]'

@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 24, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 24, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 24, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 9800c29 into nodejs:main Sep 24, 2026
81 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 9800c29

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants