tools: pin sccache on all platforms to fix benchmark CI job - #66284
Merged
Merged
Conversation
Signed-off-by: Tim Perry <pimterry@gmail.com>
Contributor
Changelog@@ -1692,0 +1693,2 @@
+/nix/store/g2gqhibqv6w58iz9287l1yr2zbjigs0y-sccache-0.17.0 (aarch64-darwin)
+/nix/store/v8y4nym7abc8f67blpmqbpwnm6nyi6a6-sccache-0.17.0 (aarch64-linux)
@@ -1694,2 +1695,0 @@
-/nix/store/cqywpjv4l1zfkqzmgi02r1z0kvx2fyai-sccache-0.18.0 (aarch64-darwin)
-/nix/store/pcw0wzcx1dc0f57rl2r7r0prc6yfwnfc-sccache-0.18.0 (aarch64-linux) |
aduh95
approved these changes
Sep 25, 2026
aduh95
added
author ready
panva
approved these changes
Sep 26, 2026
aduh95
added
the
fast-track
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Collaborator
|
Landed in 5d9228d |
nodejs-github-bot
removed
the
commit-queue
aduh95
added
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mozilla/sccache#2869 breaks sccache v0.18.0.
We pinned it back to avoid that in #66146, but just for Linux x64.
The benchmark job is now failing though, when using this same sccache version on aarch64-linux (https://github.com/nodejs/node/actions/runs/35988785748/job/107603726845) I think due to the same issue (I can't 100% confirm from the logs, but looks very likely: sccache v0.18 is used and fails to start) and further discussion in that sccache issue did confirm it's a cross-platform issue so that'd make sense.
Notably AFAICT there's no other jobs that do this combination of sccache-via-nix + aarch64-linux, which explains why it didn't come up before (the test-shared aarch64-linux job doesn't set with-sccache unlike the other platforms).
AFAICT we can safely just pin sccache for all platforms until it's fixed, and that seems like the simplest option.