Repository navigation
Conversation
Signed-off-by: lazerg <lazerg2@gmail.com> Assisted-by: Claude
Contributor
|
Caution AgentScan found account activity patterns that may be consistent with automation. This is a heuristic, not proof that this pull request was opened by an agent or violates policy. AI-assisted contributions are permitted, but automated tooling must not open pull requests without advance approval, and contributors must personally understand, test, verify, and take responsibility for every submitted change. See the AgentScan analysis, AI use policy, and automation policy for additional context. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66619 +/- ##
==========================================
- Coverage 90.43% 90.43% -0.01%
==========================================
Files 791 791
Lines 276563 276585 +22
Branches 53115 53118 +3
==========================================
+ Hits 250117 250125 +8
- Misses 16850 16860 +10
- Partials 9596 9600 +4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66611
Refs: #57867
AbortSignal.any()adds everyAbortSignal.timeout()input togcPersistentSignalsbefore it checks whether that input has already aborted. For a timeout that already fired, it then returns early. The timeout never fires again, so nothing removes it from the set, and it is never collected.This moves the aborted check in front of the timeout handling, so an aborted input is never added to the set. The new test fails without the change, and the reproduction from the issue goes from 200/200 to 1/200 retained timeouts.