Skip to content

fix(ui): fix sidebar height - #9148

Merged
ovflowd merged 3 commits into
nodejs:mainfrom
Botato300:fix/ui-sidebar
Sep 17, 2026
Merged

ovflowd merged 3 commits into
nodejs:mainfrom
Botato300:fix/ui-sidebar

Conversation

@Botato300

Copy link
Copy Markdown
Contributor

Description

Fix the sidebar height. It's a small detail, in the images you can see the differences. The sidebar was moving a few pixels down because of the header's height, so I calculated it in css: 100svh - header height and that's it!

Before
image (2)

After
image (4)

Validation

Just go to any page that has the long sidebar, like /learn. For some reason, it redirects me to nodejs.org instead of a localhost url, so you can go to /en/about/get-involved/events and add several <li> items to the sidebar, and you'll be able to reproduce it!

Related Issues

None

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Botato300
Botato300 requested a review from a team as a code owner September 8, 2026 19:01
@vercel

vercel Bot commented Sep 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Sep 14, 2026 5:28pm UTC

Request Review

@aymen94

aymen94 commented Sep 10, 2026

Copy link
Copy Markdown
Member

LGTM! Congrats on your first contribution to the repo! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.06 MB
New Total First Load JS 7.10 MB
Delta 33.50 KB (+0.46%)

Changes

🔄 Modified Routes (5)
Route Old First Load JS New First Load JS Delta
/[locale] 1.66 MB 1.67 MB 📈 6.79 KB (+0.40%)
/[locale]/[...path] 1.66 MB 1.67 MB 📈 6.79 KB (+0.40%)
/[locale]/blog/[...path] 1.66 MB 1.67 MB 📈 6.79 KB (+0.40%)
/[locale]/download/archive/[version] 1.66 MB 1.67 MB 📈 6.79 KB (+0.40%)
/_not-found 438.00 KB 444.34 KB 📈 6.34 KB (+1.45%)

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (69249e0) to head (133091d).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9148      +/-   ##
==========================================
- Coverage   86.12%   86.07%   -0.05%     
==========================================
  Files          86       86              
  Lines        6046     6046              
  Branches      357      358       +1     
==========================================
- Hits         5207     5204       -3     
- Misses        835      838       +3     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ovflowd

ovflowd commented Sep 14, 2026

Copy link
Copy Markdown
Member

Hi @Botato300 could you add a Changesets file? This has been introduced recently and we need it to merge your PR!

@Botato300

Copy link
Copy Markdown
Contributor Author

Hi @Botato300 could you add a Changesets file? This has been introduced recently and we need it to merge your PR!

Done!

@ovflowd
ovflowd enabled auto-merge September 17, 2026 10:00
@ovflowd
ovflowd added this pull request to the merge queue Sep 17, 2026
Merged via the queue into nodejs:main with commit f50e151 Sep 17, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants