fix: add missing directory constants for RC, test, and V8 canary releases - #1038
Open
bmuenzenmeyer wants to merge 1 commit into
Open
bmuenzenmeyer wants to merge 1 commit into
bmuenzenmeyer wants to merge 1 commit into
Conversation
flakey5
approved these changes
Sep 25, 2026
MattIPv4
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off of #1035
Adds
nodejs/rc/,nodejs/test/, andnodejs/v8-canary/toALWAYS_UPDATED_PATHS.These are the actively published prefixes in
KV_DIRECTORIES(which we could use...but then would have to have more logic to union anyways) that the nightly directory-cache run never refreshed, so their index pages have been frozen since the Sep 7 manual rebuild (see nodejs/node-v8#312 for v8-canary).metrics/is left out because its files update at stable nested paths, andchakracore-*because nothing is published there anymore.As with #1035, new version directories under these prefixes will still 404 until child directories are listed or the cache is rebuilt; that's the follow-up.
Assisted with analysis from a frontier agent