Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash on empty values
A setting with an empty value makes
loadFilethrow, so the application never starts.Minimal example for reproducing it
.env:Main.purs:Crashes with:
The same happens for
OPTIONAL_SETTING=""andOPTIONAL_SETTING='', anywhere in the file.Cause
The value parser requires at least one piece (
some), so an empty value never matches.Fix
Allows zero pieces (
many) in quoted and unquoted values, and maps an empty value toLiteralValue "". Empty values now resolve to the empty string.Also adds a parser test for
A=.