Repository navigation
docs: make the data, actions, workflows and approvals code samples parse with @objectstack/spec 17.7.0 (part 1 of #316) - #320
Merged
Conversation
…ds or fewer Adds a `seoTitle:` frontmatter line to every English page whose built `<title>` read as one or two words plus the ` | ObjectOS` suffix, so the tab/result title carries the terms a reader searches for while the H1, sidebar and breadcrumb keep the short noun (#166's mechanism). - 67 pages: each gains exactly one line; no `title`, `description` or body line changes. - Every title leads with the page's own specific term, lifted from its description and headings, and renders at 52–60 characters including the suffix (measured on the built HTML). - The three duplicated titles (Approvals, Dashboards, Notifications — each used by a build/configure page and a use page) are now distinct. - English only. Locale siblings are translation artifacts that a non-translator commit may not modify (AGENTS.md, Translation workflow; check-translation-ownership.mjs); the translation pass carries the new key over, and the output report lists the 163 siblings now missing it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…AQ headings, title-weighted per-locale search, consistency pass - Light-mode muted foreground to hsl(0 0% 40%); code comments recoloured in both shiki themes. - Tables get an always-drawn scrollbar and a scroll-driven trailing fade. - FAQ and License FAQ questions become headings. - /api/search builds one locale's index on that locale's first search and weights title > heading > text; check-search-locales gains own-title-buried; smoke-docs asks /api/search in every locale with a nonce control. - Consistency: one data-residency table, one license-validation sentence, ObjectSchema.create, "license" spelling, Configure title, glossary order plus AI seat and Position, logo to the docs home, a translated llms.txt example, three unsourced configure/ai claims removed (with their locale siblings), release-following lines pointed at a populated feed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…comments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ix apiMethods primitives
The Views page declared views inside a defineObject call under an
object-level `view` key. ObjectStack provides no defineObject, and
ObjectSchema.create rejects `view` as an unknown key. Its views are a
defineView container ({ list, listViews, form, formViews }, each view
bound through `data`) registered on the stack with `views: [...]`, which
both samples now show; both parse with @objectstack/spec 17.6.0.
The REST API page's allowed apiMethods values drop the eight retired ones
the spec strips at parse.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ype-check `next typegen` loads next.config.mjs, and fumadocs-mdx 15.0.7's createMDX() starts init() without awaiting it (dist/next/index.js:14-20). init rewrites every .source/*.ts with fs.writeFile (dist/core-DlDe_Eze.js:232-236), which truncates first. typegen ends in process.exit(0), so it can exit inside that window and leave .source/server.ts empty for tsc: TS2306, CI run 37478051451. Running the fumadocs-mdx CLI after typegen makes the CLI, which awaits its writes, the last writer before tsc. typegen does not read .source. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ries, zh-Hant 404, Open-in links follow the page shown - patches/fumadocs-ui@16.8.12.patch: the nine accessible names fumadocs-ui 16.8.12 hard-codes in English (Open Search, Toggle Theme, Open/Collapse Sidebar, Copy Anchor Link, Copy/Copied Text, Toggle Menu, and Radix's "Main") read from its i18n context with the old literal as default. Eight keys are a backport of upstream 16.9.0's own names; lib/ui-text supplies all nine through RootProvider in every locale. - app/[lang]/docs/layout.tsx: page-tree entries (sidebar, breadcrumb, prev/next footer) for pages a locale has no translation of carry lang="en", using the docs page's own translatedLocales detection. - app/not-found.tsx: the 404 copy moves into lib/ui-text (notFound), so the zh-Hant string is generated from zh-Hans by gen-zh-hant and checked by --check like every other Traditional string. - Open in ChatGPT / Claude on a translated page sends the assistant to the translated page itself; English pages and fallbacks keep the English .mdx. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…pec 17.7.0 views.mdx: every list-view fragment carries its required top-level columns, fontWeight is a string, the list view types table states the required keys the spec declares, and each fragment says what it omits. flows.mdx: every sample is rewritten from the old trigger/steps shape to FlowSchema's nodes and edges. Email goes through a notify node with channels: ['email']; requires lists automation and triggers. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ative GitHub icon, code blocks off the landmark list, a localized Open-in prompt axe 4.14.0 reported four failures on every docs page in every locale, English included (#308): - landmark-one-main: the docs layout has no main landmark. DocsPage passes its other props to the article it renders, so the docs page sets role="main" there; no patch needed. - label-content-name-mismatch: the language switcher shows the current language but was named "Choose a language" only. It is now named "English — Choose a language", "Deutsch — Sprache wählen", visible text first, both halves from the i18n context. - svg-img-alt: the GitHub icon was an svg role="img" with no name inside a link already named "GitHub"; it is aria-hidden now. - landmark-unique: every code block's scroll viewport was an unnamed role="region". The role goes; tabIndex 0 stays for keyboard scrolling. The last three are hunks added to patches/fumadocs-ui@16.8.12.patch; its header says why each is a hunk and not a slot, and what an upgrade must re-check. None of the three is fixed upstream as of 16.16.2. The "Open in ChatGPT / Claude" prompt sentence was English in every locale. It is now the ui-text key pageActionsOpenInLLMPrompt, upstream 16.9.0's key name, placeholder and English, translated in six locales and generated for zh-Hant. ui-text's table() now also holds every locale's placeholders to English, so a translation that drops {url} fails the build. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ree entries #298 and #305 made two promises about every localized docs page that no gate checked afterwards: no control is named in English, and every page-tree entry for an untranslated page carries lang="en". The locale surface gate now reads them off the prerendered HTML under apps/docs/.next/server/app/<locale>/, script bodies (the RSC payload) skipped: - english-chrome-name: an accessible name (aria-label, title, alt, placeholder, svg title, .sr-only text) on a localized page that is one of the English pages' names, outside lang="en". The English set is read off the built English pages, minus GitHub and www.objectos.ai. - untranslated-entry-unmarked: a sidebar item or previous/next card for a page the locale has no source file for, whose text does not resolve to lang="en". The oracle is the content tree, not the app's detection. - translated-entry-marked-english: the over-marking direction. Guards keep it from passing over nothing (a page missing from a locale's build, no English name to compare, no entry of a kind recognised in a locale), and a live control feeds both #305 shapes, built from the run's real oracle values, through the same reader on every run. Ten self-test cases, and the control shown red with a reader blinded to names or to lang. On the HTML main built at cec227a it reports 6239 English names and 5974 unmarked entries; on #305's tree, 0 and 0. No ci.yml change: the existing Locale surface step runs the gate after the build, and pnpm turbo run test runs its self-test. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
Below 1280px fumadocs-ui 16.8.12 shows the page's table of contents as a bar rendered in a <header> outside every sectioning element, so the page had two banner landmarks: the site header (#nd-subnav) and this bar. axe 4.14.0 at 390px reported landmark-unique and landmark-no-duplicate-banner on all 48 runs of the #308 sample (8 sections, en/zh-Hans/de, light/dark), on the tree that already carried the other #308 fixes. The bar is a disclosure for the page's headings, so the patch renders it as a <div>; no CSS selects header by element, and the 390px screenshots do not change. Upstream 16.16.2 still renders it as a <header>. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…e inside an English body #305 localized the names of the heading-anchor and code-copy buttons. On a fallback page both buttons sit in the page body, which #298 marks lang="en", so "Ankerlink kopieren" was read with English rules: WCAG 3.1.2, the inverse of what #305 fixed. On main at cf449fa that was 520 + 115 names per Latin-script locale over 55 fallback pages, and 336 + 58 in zh-Hans and zh-Hant over 31. Both buttons now take locale from the useI18n() they already read and render it as their own lang (patches/fumadocs-ui@16.8.12.patch, the two #305 hunks). On a page in the route locale this repeats what html lang says; inside an English body it keeps the name in its own language. check-locale-surface.mjs gains the inverse rule, localized-name-marked-english: one of a locale's own names (read off its built pages, the names that resolve to the locale, minus the English set) inside a lang="en" region with no lang of its own fails. Two self-test cases (red as #305 shipped it, green through an inherited lang), the fixture body now carries a localized anchor button with its own lang, and the live control feeds the inverse shape too, shown red with a reader blind to lang on names. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
The "nothing built" guard in check-locale-surface.mjs fired artifact-missing only when no locale directory held any HTML at all. The legal pages and the locale roots live in the same directories, so a build (or a fixture tree) holding them but no docs page fell through to one docs-page-html-missing per page plus the blind-reader guards. #312 adds legal-page fixtures to every self-test case, and with them this file's "docs pages not built" case read exactly that way. Measured on this tip with #312's own two commits applied in memory (git merge-tree --merge-base 4da46c5): before this change 1 self-test case failed, after it 48 cases over 25 rules pass. The guard now asks whether any <locale>/docs page was built. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ce; zh-Hant generated from zh-Hans - privacy and terms on de, ja, es, fr and ko: the English entry is marked lang="en" (title, date, body, back link) and introduced by the #298 notice (ui-text notTranslated) in the route locale. en and zh-Hans render as before. - The zh-Hans entry of each page moves, unchanged, into a zh-Hans.json beside it; gen-zh-hant converts it to zh-Hant.json like lib/ui-text, so /zh-Hant/privacy and /zh-Hant/terms show Traditional text and gen-zh-hant --check covers it. contentLocales, hreflang and the sitemap gain zh-Hant. - check-locale-surface: STATIC_PAGES lists zh-Hant, and three rules read the built legal pages (legal-english-unmarked, legal-translation-shows-english, legal-page-unread), with self-test cases. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…econd main HomeLayout already renders main#nd-home-layout around its header and the page, so the page's own main was a nested, duplicate landmark on /privacy and /terms in every locale (axe: landmark-no-duplicate-main, landmark-main-is-top-level, landmark-unique). Same classes, so nothing moves on screen. The check-locale-surface legal fixture now mirrors that structure. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…capability claim Rule 3 ended "When in doubt, delete rather than leave behind", and the Retiring a page section told authors never to leave a translation behind for a page "rewritten to say something different". Read literally, both delete a whole translated page over a changed port number, which AGENTS.md step 2 and the new step 3 say stays with the translation pass. Both now state the ruled line: an English correction that removes or reverses a capability assertion deletes the page's locale siblings in the same PR, and wording and number drift stay with the pass. Rule 3 links the ruling. GUIDE_REV is not bumped: no existing translation output becomes invalid. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
…ack/spec 17.7.0 First half of the docs code-sample family close-out (#316): the samples on eight English pages now parse with @objectstack/spec 17.7.0, the npm latest. - workflows: the XState-style StateMachineConfig left the spec. A workflow is the `state_machine` validation rule on the object, with `requiredWhen` for "no resolved case without a resolution". The side-effect flow gets its labels and node configs. automation/index stops promising events and guards. - approvals: labels on the start and end nodes, real `update_record` configs, and `resolveAs` moved onto the `expression` approver. - actions: `Action` from `@objectstack/spec/ui`; the confirm question moves from `confirmText` to `description`. There is no flow node that calls an action and no view `actions` key, so the flow-step surface goes, placement is the action's `locations`, and a list view names `rowActions` / `bulkActions`. - data/index: the stack namespace prefix, `inlineHelpText`, a `format` rule in place of field `pattern`, typed validation rules, the real ownership values and lifecycle shape, and no `decimal` type. - relationships, formulas, validation-rules: `Field.masterDetail` and `Field.lookup` take the reference first, `Field.decimal` does not exist, option placeholders become real options, and fragments say what they are. Locale siblings follow ruling A of #256: deleted for workflows, automation/index, actions and data/index (18 files), where a capability assertion is removed or reversed; kept where the change is code shape only. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FeA1nwBz1ohH65dvffUGKr
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #316
This is the first of two stacked PRs that close the docs code-sample family (#301, #307, #316). Here, the samples on eight English pages parse with the latest published
@objectstack/spec, 17.7.0 (npmlatest, published 2026-10-06T12:22Z; versioned in objectstack4e4e8814, "chore: version packages (#21352)"). The pages are the data model and its three subpages,actions, and the three automation pages. The locale siblings that ruling A requires go with them. PR B, stacked on this one, fixes the other 14 pages and adds the CI gate. It closes the card; #316 stays open until then.Why two PRs: together the change is 8334 changed lines (+1354/−6980). Most of that is deleted translations, and it is over the 5000-line human-merge threshold. This PR is 4054 (+254/−3800).
check-governed-merges --teston this PR's 26 paths, with that size, answers "NOT governed … 4054 changed line(s) ≤ 5000". Each English correction ships here with its own sibling deletions, as ruling A requires.One commit:
e585f02, onmain@dc8213d.What changed, per page
Sources are the published spec,
packages/spec/src/**at objectstack4e4e8814. The npm tarball ships the same files; three were compared byte for byte. ObjectStack's public docs at the same commit are cited as "ObjectStackcontent/docs/…".build/automation/workflows.mdx: rewritten around thestate_machinevalidation rule.StateMachineConfigis not in 17.7.0: there is no such type and no schema. "The XStateStateMachineSchema… left the package in #21320" (api/protocol.zod.ts:2621).validations, thestate_machinerule:field,transitions,initialStates(data/validation.zod.ts:187). The pattern is ObjectStack'scontent/docs/automation/workflows.mdxandprotocol/objectql/state-machine.mdx.has_resolutionguard becomesrequiredWhenonresolution, which is a transition gate (data/field.zod.ts:1817). The state-machine page says "Astate_machinerule has no per-transition guard".condguards,type: 'final'(now an explicit[]), and "Events, not field writes", which becomes "Writes, not events".status, and realupdate_record/notifyconfigs.{TODAY()}is the documented value interpolation (ObjectStackautomation/flows.mdx:1895).build/automation/index.mdx: the chooser said "by these events" and "states, transitions, and guards". It now says what the workflows page says.build/automation/approvals.mdx:update_recordnodes get real configs.resolveAsmoves onto theexpressionapprover, the key the approval contract reads (automation/approval.zod.ts:505). As a node-config key it is refused.legal_reviewnode gets a label.approve/rejectedge labels stay; they are documented at:382.build/interface/actions.mdx:Actionis imported from@objectstack/spec/ui: the root entry point exports noAction.confirmTextbesideparamsis refused ("TWO dialogs for one decision"), so the question moves todescription, as the refusal prescribes (ui/action.zod.ts:2087).type: 'action')" surface and the "From a flow" sample are removed. The section now shows the other direction, an action withtype: 'flow'(ObjectStackprotocol/objectui/actions.mdx).actionskey. Placement is the action'slocations, and a list view namesrowActions/bulkActions(ui/view.zod.ts:2826).build/data/index.mdx:namespaceistodo:defineStackrefusestodo_taskundermyapp.helpTextbecomesinlineHelpText.patterndoes not exist. The regex moves to aformatrule.type, andconditionis the invalid case.ownershiptakes'user' | 'business_unit' | 'org' | 'none'.lifecycleusesretention: { maxAge }andstorage: { strategy: 'rotation', shards, unit }(data/object.zod.ts:904).decimal, which does not exist, and fixes theField.lookup/Field.masterDetailsignatures:(reference, config).build/data/relationships.mdx:Field.masterDetail('order', …); realoptionson the grade select; the summary fragment says it is a field of the Order object.build/data/formulas.mdx:Field.decimaldoes not exist; it becomesField.currency/Field.number({ scale }). The rating select gets real options.build/data/validation-rules.mdx: fragments say what they are, the status select gets real options, and the mixedemail/indexesfragment becomes the object keys it is.Locale siblings: ruling A of #256 (
AGENTS.md, #319)build/automation/workflowsbuild/automation/indexbuild/interface/actionsbuild/data/indexdecimaltype, fieldpatternand the ownership values are removedapprovals,relationships,formulas,validation-rules18 files are deleted. Before each deletion, I confirmed that the sibling carries the claim.
gen-zh-hant --checkpasses with 58 files.Parse results:
@objectstack/spec17.7.0The checker is PR B's
check-doc-samples.mjs, run against this branch's tree. "Unchecked" means a fragment with no comment saying what it is. The middle column adds only those comments, to show what the fragments held.build/automation/index.mdxhas no code block.Across the whole English corpus:
dc8213dgives✗ doc samples: 66 block(s) refused or unchecked on 21 page(s). This branch gives✗ … 39 block(s) refused or unchecked on 14 page(s) · 62 pass. All 39 are on the 14 pages PR B fixes: agents 1, apps 3, dashboards 7, forms 3, pages 4, data-sources 4, field-level-security 1, permission-sets 1, record-access 1, quickstart 1, cel 7, field-types 4, objectql 1, rest-api 1. The gate is not in CI on this branch; PR B adds it.Verification at
e585f02pnpm install --frozen-lockfilepnpm turbo run type-check --continue --force(lock)✓ Types generated successfully· 1 successful, 0 cachedNEXT_PRIVATE_STANDALONE=true pnpm turbo run build --force(lock)pnpm turbo run test --force(lock)✓ 10 self-test(s) passedcheck-locale-surface.mjs✓ every advertised URL has a source file and every source file is advertised; …check-positioning.mjs✓ positioning: 4 copies equal their constants; the brand is right in 659 pages and 2 llms bodies; no stale sentence in 79 English sources and the en entry of 2 legal pagescheck-search-locales.mjs✓ search locales: all 8 locales answer 200, find "permissions", find every own page by its title within the first 3 pages, and find nothing for a noncegen-zh-hant.mjs --check✓ zh-Hant: 58 generated file(s) match the zh-Hans sources byte for byte.git diff --name-status --no-renames origin/main...HEAD),--actor hotlong,TRANSLATION_BOT_LOGINset✓ 26 file(s) changed: 18 translation artifact(s) deleted, none added or modified.With the bot as actor (the control): EXIT 1check-translations.mjs✓ translations gate passed. Reported, not blocking: zh-Hans 43 stale / 35 missing; the others 22 stale / 57 missingcheck-translation-output.mjs --self-test/--files✓ translation output gate passed (235 pre-existing finding(s) reported)check-node-floor.mjs, with--self-test;check-half-states.mjs --self-test1551 cases passBrowser. These pages are byte-identical to the reviewed
staged/issue-316work, so the earlier measurements still apply.next startserved that build, and Chromium loaded each page at 1440 and 390: HTTP 200, the right h1,scrollWidthequal to the viewport, and every code box inside it (303–1137 px at 1440, 17–373 px at 390)./zh-Hans/docs/build/automation/workflowsand/ja/docs/build/interface/actionsanswer 200 with the English body.NOT MEASURED: behaviour on a running ObjectOS runtime.
Acceptance notes
build/data"Computed" table listscreated,lastModified,createdByandlastModifiedByas field types, which are not inFieldType. It is a table, so no gate sees it.staged/issue-316-b's tree equals the reviewed853ed96merged ontodc8213d(tree80a304d).Pushed head
c57caa2onclaude/pm-dispatch-objectos-ju9td1, a fast-forward with no force. It starts at the remote branch heade463447, mergesorigin/main@dc8213d(after the merge the diff againstmainis empty), and cherry-pickse585f02.git diff origin/main c57caa2is byte-identical togit diff dc8213d e585f02. Size: 26 files, +254/−3800 = 4054 changed lines, under the 5000-line human-merge line. PR B (Fixes #316, the other 14 pages and the gate) follows on top of this one.Generated by Claude Code