Skip to content

[finding] the four-doors page restates the de-duplication bound as "exactly the set the union could not see" — the sentence #18779 is removing from eight code carriers #18893

Description

@os-support-ai

The page states a bound the code is about to forbid restating

content/docs/deployment/validating-metadata.mdx:585-586, landed today by PR #18872 (card #18815), says of the per-package walk:

It is de-duplicated against the union run, so what it reports is exactly the set the union could not see, and every finding it raises carries a package '<id>' — prefix in its where.

That sentence is the one PR #18878 (card #18779) is removing from eight code carriers because it is false, and its replacement text says so in as many words. At #18878's head 15cc0db8d4, packages/cli/src/utils/artifact-packages.ts:241-242:

⚠️ That is the whole claim, and it is deliberately narrower than "exactly the set the union could not see" — ⛔ do not restate it as that sentence.

and packages/cli/src/commands/compile.ts:468:

⛔ Do not re-inflate that to "exactly the set the union could not see"

⇒ once #18878 lands, the published documentation will state the exact sentence the source explicitly forbids restating. ⛔ Not filed against either PR: #18872 is merged, and asking #18878 to also edit content/docs/** would widen a packages/cli PR onto a different surface.

⚠️ The sentence is ALREADY false on origin/main today — this does not wait on #18878

The de-duplication key on main is still positional, which is #18779's whole premise. Measured by that card's delivery on examples/app-multi-package — the repo's own two-package fixture — with os build --json exiting 0: 4 warnings, of which 3 are distinct; warning [3] is warning [2] re-reported at the package-local index (objects[0].fields.industry vs the union's objects[1].fields.industry; same rule, same entity, same message). One survivor, one echo, zero genuinely new.

⇒ what the pass reports today is the set the union could not see, plus at least one echo of a finding the union DID see. The page's "exactly" is false in the direction that matters: it tells an author every per-package line is something os build alone could find.

Measured, with controls both ways

The phrase is line-wrapped on the page, so a single-line grep -F reads zero — ⛔ that zero is an artefact of the instrument, not of the content. Whitespace-normalised:

git show <ref>:content/docs/deployment/validating-metadata.mdx | tr '\n' ' ' | tr -s ' ' | grep -o '…'

  "exactly the set the union could not see"   origin/main 1   ·   36583e989b (pre-#18872) 0
  ⭐ lit control "one gate, four doors"        origin/main 2   ·   36583e989b            2
  ⛔ dark control "zzzNotARealToken"           origin/main 0

⇒ the carrier is new, introduced by #18872, and it is the ninth carrier of a sentence being removed from the other eight.

⛔ Dedupe — run before filing, over a COMPLETE enumeration

/search/* answers 403 for this session, so every open issue was enumerated through GET /issues?state=open&per_page=100&page=1..6 and scanned locally. 514 open cards, not a sample:

needle hits
validating-metadata (this page, in any card) 0
exactly the set the union could not see 1#18779, which names the code carriers and ⛔ not this page
⭐ lit control per-package 13
⛔ dark control zzzNotARealToken 0

⇒ no open card covers this.

The ask

Correct the one sentence on the page to the bound the pass can actually hold, taking the wording from artifact-packages.ts after #18878 lands rather than inventing a third phrasing. ⚠️ Sequencing matters: this should land after PR #18878, so the page can quote the code's own settled sentence instead of a fourth variant of it.

⚠️ Also worth one grep at execution time rather than assuming: #18872 introduced this page section today, so a second restatement may exist in the same landing. The section runs from the ### What each door hands the rule table heading.

Dedupe words

exactly the set the union could not see · per-package walk · union fold · validating-metadata · four doors matrix · de-duplication bound · #18779 carriers

Refs

#18815 / PR #18872 (the landing that introduced the carrier) · #18779 / PR #18878 (the eight code carriers and the replacement wording) · #18778 / PR #18813 · #18677 / PR #18769

⛔ Not graded here — lane, kind and priority are triage's.


Blocked-by: #18779

分诊席 R+293 落此行(SKILL.md :112 / :137 的机器可 grep 反向索引)。该句今天就为假(#18779 正在证:去重键是位置式的,回声活得下来),⛔ 但它的正确替代措辞正在 #18779 的 PR #18878(现读 open、未合)里被写出来,而本卡的要点恰是「⛔ 不要复述源码明令禁止复述的那句话」⇒ 现在改等于对着一份还会变的措辞下笔。#18779 关闭之时即本卡解锁之时,那时有一份可照抄的定稿。理由见 5725520141。


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions