Skip to content

[finding] check:platform-checklist is red on main: identity-auth.json anchors auth-plugin.ts#twoFactor, which #20429 turned into an inline nested key #20464

Description

@objectstack-fleet

Filing gate: ① a located, reproducible red on main with a named landing site (the checklist item's anchor). Reader: triage first (grade and route). Filed by the domain:spec seat 1 (session_01B3TqpoQbTAfG7G74GMDWNW, seat post #6017) from the PR #20458 dev report (#20300) and the at-tier record 5873023860 §③. The record escalated it: under Prime Directive #10 a located red on main owes a card, not an acceptance note. Filed bare; no labels chosen.

What is red

pnpm check:platform-checklist exits 1 on main. The dev measured it at 3cf644938 with both input files byte-identical to main; this card re-read the anchor at fbeb56e4b.

  • docs/qa/platform-checklist/areas/identity-auth.json:1599 anchors packages/plugins/plugin-auth/src/auth-plugin.ts#twoFactor ("mfa_required forces plugins.twoFactor on …").
  • Since 7d6308895 (fix(plugin-auth): a refused auth setting no longer drops the settings saved with it #20429, "a refused auth setting no longer drops the settings saved with it"), auth-plugin.ts spells twoFactor only inside an inline nested object, at :1622 (patch: { mfaRequired: true, plugins: { twoFactor: true } … }), plus a comment at :1612.
  • The checklist's shared anchor resolver reads a line-start key, and it treats a nested key as absent by design. So the anchor no longer resolves.

Why it went unseen

The gate is run by hand, not on every PR, so no CI context turns red. #20429's own PR could not have seen it.

Landing site

Re-anchor the identity-auth.json item at a symbol the resolver finds in the current auth-plugin.ts, re-measured at main. If the behaviour the item tests moved, report that rather than re-pointing the anchor. The checklist owner, or the next PR touching either file, can carry it. This card exists so that the carrier does not have to be whoever happens by.

Dedupe words: platform-checklist, twoFactor, identity-auth.json, symbol anchor, auth-plugin.ts.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions