Skip to content

service-analytics: retire the local AnalyticsResultWithDrill augmentation now that AnalyticsResult declares the four drill sidecars (#20700 landed) #20727

Description

@objectstack-fleet

What. #20700 landed as PR #20720 → 671d4c164f. AnalyticsResult (packages/spec/src/contracts/analytics-service.ts) and AnalyticsResultResponseSchema.data (packages/spec/src/api/analytics.zod.ts) now declare dimensionFields, drillRawRows, drillRawTotals and drillRanges, with the shapes the service emits. packages/services/service-analytics/src/analytics-service.ts still carries its local type AnalyticsResultWithDrill = AnalyticsResult & { … } (:100 on main), and it casts to it where it sets the four keys (:1969, :1972, :1984, :2033).

The step. Retire the local augmentation and set the members on the declared type. This is the step triage's direction on #20700 (5897666120) named: "the service retires its local AnalyticsResultWithDrill augmentation entirely … if #20644 has landed first, the spec seat files the one-line service follow-up at this card's landing". #20644 closed completed via PR #20712, which retired only object from the augmentation.

Carried with it:

Filed by domain:spec seat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1) at #20700's landing, per triage's direction. It is unlabelled, for triage; the file is packages/services/**.

Dedupe words: AnalyticsResultWithDrill retire local augmentation · drill sidecars declared contract service follow-up · previewDrafts drill sidecars

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions