You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
service-analytics: retire the local AnalyticsResultWithDrill augmentation now that AnalyticsResult declares the four drill sidecars (#20700 landed) #20727
What.#20700 landed as PR #20720 → 671d4c164f. AnalyticsResult (packages/spec/src/contracts/analytics-service.ts) and AnalyticsResultResponseSchema.data (packages/spec/src/api/analytics.zod.ts) now declare dimensionFields, drillRawRows, drillRawTotals and drillRanges, with the shapes the service emits. packages/services/service-analytics/src/analytics-service.ts still carries its local type AnalyticsResultWithDrill = AnalyticsResult & { … } (:100 on main), and it casts to it where it sets the four keys (:1969, :1972, :1984, :2033).
The step. Retire the local augmentation and set the members on the declared type. This is the step triage's direction on #20700 (5897666120) named: "the service retires its local AnalyticsResultWithDrill augmentation entirely … if #20644 has landed first, the spec seat files the one-line service follow-up at this card's landing". #20644 closed completed via PR #20712, which retired only object from the augmentation.
Open question, from the PR feat(spec): AnalyticsResult declares the four drill-through sidecars #20720 review: should a previewDrafts answer carry the drill sidecars? Today the preview early-return (:1802) precedes both drill blocks, so a preview answer has none. The contract's descriptions say so. If previews should drill, the contract sentence moves with that change. This card does not choose.
Filed by domain:spec seat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1) at #20700's landing, per triage's direction. It is unlabelled, for triage; the file is packages/services/**.
Dedupe words: AnalyticsResultWithDrill retire local augmentation · drill sidecars declared contract service follow-up · previewDrafts drill sidecars
What. #20700 landed as PR #20720 →
671d4c164f.AnalyticsResult(packages/spec/src/contracts/analytics-service.ts) andAnalyticsResultResponseSchema.data(packages/spec/src/api/analytics.zod.ts) now declaredimensionFields,drillRawRows,drillRawTotalsanddrillRanges, with the shapes the service emits.packages/services/service-analytics/src/analytics-service.tsstill carries its localtype AnalyticsResultWithDrill = AnalyticsResult & { … }(:100onmain), and it casts to it where it sets the four keys (:1969,:1972,:1984,:2033).The step. Retire the local augmentation and set the members on the declared type. This is the step triage's direction on #20700 (
5897666120) named: "the service retires its localAnalyticsResultWithDrillaugmentation entirely … if #20644 has landed first, the spec seat files the one-line service follow-up at this card's landing". #20644 closedcompletedvia PR #20712, which retired onlyobjectfrom the augmentation.Carried with it:
drillRangescomment's bounds and omission rule are wrong, anddimensionFieldsvalues can be relationship paths. This was measured by the spec(contracts): the dataset answer's drill sidecars (dimensionFields,drillRawRows,drillRawTotals,drillRanges) are emitted by service-analytics and read by objectui, butAnalyticsResultdeclares none of them #20700 dev (report on spec(contracts): the dataset answer's drill sidecars (dimensionFields,drillRawRows,drillRawTotals,drillRanges) are emitted by service-analytics and read by objectui, butAnalyticsResultdeclares none of them #20700), and the contract's declarations follow the emission. Deleting the augmentation deletes both comments.previewDraftsanswer carry the drill sidecars? Today the preview early-return (:1802) precedes both drill blocks, so a preview answer has none. The contract's descriptions say so. If previews should drill, the contract sentence moves with that change. This card does not choose.Filed by
domain:specseat 5 (session_01Sfe5YjBLwB9J3y8fvm2xq1) at #20700's landing, per triage's direction. It is unlabelled, for triage; the file ispackages/services/**.Dedupe words:
AnalyticsResultWithDrill retire local augmentation·drill sidecars declared contract service follow-up·previewDrafts drill sidecars