Skip to content

fix(scripts): check-issue-citations reads a qualifier only when it names a known repository, so pre-#N / post-#N are judged and framework#N is this repository #20554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 3 commits into from
Sep 29, 2026
Merged

fix(scripts): check-issue-citations reads a qualifier only when it names a known repository, so pre-#N / post-#N are judged and framework#N is this repository #20554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b497cc
wip(scripts): check-issue-citations reads a qualifier only when it na…
claude Sep 29, 2026
847867e
wip(scripts): check-issue-citations self-test pins every qualifier sp…
claude Sep 29, 2026
a3c1475
docs(spec): the SelectOptionSchema visibleWhen docblock qualifies eac…
claude Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/spec-field-option-visiblewhen-pair-qualified.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'@objectstack/spec': patch
---

A field-option docblock names both sibling issues by repository

The docblock on `SelectOptionSchema`'s `visibleWhen` in `src/data/field.zod.ts` cited a pair
of objectui issues as `objectui#6110 + #6111`, which reads the second number as
this repository's. It now qualifies each number on its own, so both point at the
objectui records the sentence describes. Comment only: no type, schema, export
or runtime behaviour changes.
2 changes: 1 addition & 1 deletion packages/spec/src/data/field.zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ export const SelectOptionSchema = lazySchema(() => strictObject({
* Options resolve through `resolveCascadingOptions` against that scope
* (ADR-0068 / objectui#2284), while field- and section-level rules go through
* `evalFieldPredicate` — a different evaluator, but since objectui#6010 (field)
* and objectui#6110 + #6111 (section) it is handed the same host scope, so
* and objectui#6110 + objectui#6111 (section) it is handed the same host scope, so
* `current_user` resolves on those surfaces too. What still separates this one
* is ENFORCEMENT, not vocabulary: per-option `visibleWhen` is the only
* VISIBILITY predicate the SERVER also evaluates — the rule validator refuses
Expand Down
Loading
Loading