Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/20597-react-prop-deprecated-message-words.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
'@objectstack/lint': patch
---

The `react-prop-deprecated` warning states its reason in words instead of citing a tracker number

The finding `validateReactPageProps` reports for a react-page prop written in a
deprecated react-tier spelling used to end by pointing the author at an issue
number that no longer resolves. It now says what that decision was, in the
sentence being read: the react tier converges on the metadata-tier vocabulary,
so the deprecated spelling keeps working through the deprecation window and is
removed after it. The block tag, the prop and the canonical metadata-tier
spelling it names are unchanged, and so are the rule id, the `warning`
severity, the hint and every other finding.
2 changes: 1 addition & 1 deletion packages/lint/src/validate-react-page-props.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ export function validateReactPageProps(stack: AnyRec): ReactPropFinding[] {
severity: 'warning',
rule: REACT_PROP_DEPRECATED,
where, path,
message: `<${tag}> prop "${u}" is the deprecated spelling of the metadata-tier "${dep.replacedBy}" and is removed after the deprecation window (#11284).`,
message: `<${tag}> prop "${u}" is the deprecated spelling of the metadata-tier "${dep.replacedBy}": the react tier converges on the metadata-tier vocabulary, so this spelling keeps working through the deprecation window and is removed after it.`,
hint: dep.note,
});
}
Expand Down
1 change: 0 additions & 1 deletion scripts/doc-authoring-prose-id.baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,6 @@
"#7696": 1
},
"packages/lint/src/validate-react-page-props.ts": {
"#11284": 1,
"#5583": 1
},
"packages/lint/src/validate-readonly-flow-writes.ts": {
Expand Down
Loading