docs(spec): four conversion summaries state their decision in words instead of a deleted tracker number (stage 9) - #20718
Conversation
…that cited deleted tracker numbers (stage 9) Ruling C+D form D: a conversion `summary` is author-shown (`os migrate meta`, spec-changes.json, the protocol upgrade guide), so it carries the lesson, not a number to look up. The four numbers removed answer 404 on the board; the lit reference in the submitLabel summary stays. No id, surface, verdict or code token moves. The comment clause at the withdrawn field-required-notnull-explicit entry said every docblock around retiredFromLoadPath misstates it; the flag's own docblock has stated the authoring-only reach since commit 29dd1a6, so the clause now says that. Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx Co-authored-by: Claude <noreply@anthropic.com>
…ide for the reworded mongo conversion summary Generated by gen:spec-changes and gen:upgrade-guide; only the one summary's copy moves (two JSON lines, one guide table row). Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014EJ1ED8X4MMrT18BhVx4tx Co-authored-by: Claude <noreply@anthropic.com>
…nversion-summaries-form-d
📓 Docs Drift CheckThis PR changes 1 package(s): ⛔ 1 release-owned page(s) name something this change touched. These are read-only:
What this run could not see
Coarse fallback — 137 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): Which tree this was computed onThis run read A worktree cut from an older # while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 0126aaf052db44fd67aade978d1de9ebe4fc3c86 && git checkout 0126aaf052db44fd67aade978d1de9ebe4fc3c86
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin dfc8547c4b4fd2e5e5780409b2b0a0e02a220f19 7ec0ef4c84bf4a4e0ca7e51c780da6d46cfa0708 && git checkout -B drift-repro dfc8547c4b4fd2e5e5780409b2b0a0e02a220f19 && git merge --no-ff 7ec0ef4c84bf4a4e0ca7e51c780da6d46cfa0708
node scripts/docs-audit/affected-docs.mjs --json dfc8547c4b4fd2e5e5780409b2b0a0e02a220f19
|
Contract reviewServed-tier: Read-only review of PR #20718 (card #20234, stage 9) against ruling C+D on #19123 ( ① Derived judgmentsDiff shape. Net diff against
The four
The Generated artifacts. Hypothesis 5 (neither gate counts a conversion Public surface and accept set. No export, schema, accept-set, reject-set or runtime behaviour changes; what changes is author-shown text ( ② Semver level
Clause-②: no — right; the PR body and the changeset each carry it as a standalone line. ③ Boundary flagsDev flags (the report's
Out-of-scope findings, judged:
Check-runs on the head (one read of 32 runs, 0 failed, taken after the newest run's
Implemented-by: VERDICT: PASS Generated by Claude Code |
Part of #20234
Clause-②: no
Stage 9 of the dead-citation sweep. Four conversion
summaryliterals inpackages/spec/src/conversions/registry.tscited tracker numbers that no longer exist on the board. Asummaryis author-shown:os migrate metaprints it, andgen:spec-changes/gen:upgrade-guideproject it intopackages/spec/spec-changes.jsonanddocs/protocol-upgrade-guide.md. So each now takes ruling C+D form D: the decision in words, no number to look up. One stale comment clause at:2100is rewritten to be true (form C). No conversion id, surface, retirement state, transform or code token moves.What changes
datasource-driver-mongo-to-mongodb(#6345)translation-component-submit-label-removed#10926 —mapping-lookup-params-removed#10329,connector-error-mapping-removed#14676,The other number in the submitLabel literal, #9249, is live (200) and stays.
ADR-0049stays in the two literals that carried it.The comment at
:2100said the flag "does not mean what its name and every docblock around it say it means". That has been false since commit 29dd1a6, which rewrote the flag's own docblock to state its authoring-only reach. It now reads: "does not mean what its name says: its own docblock (RetiredConversionStateintypes.ts) has stated the authoring-only reach since commit 29dd1a6." Evidence:git log -S"its reach is the authoring surface" -- packages/spec/src/conversions/types.tsanswers 29dd1a6 only;rev-parse --disambiguatecount 1;merge-base --is-ancestorexit 0 against the base and against HEAD;GET /repos/objectstack-ai/objectstack/commits/29dd1a6ddanswers 200 with the full sha, and the 4-character control29ddanswers 422.Verification
Base
e4e5222b7b; head7ec0ef4c84(the base plus three commits, thenorigin/main5757463712merged throughscripts/pm/os-regen-merge.sh; that merge touched no path underpackages/specorscripts, and the post-merge regeneration produced no diff).Deadness. REST
GET issues/N, no redirects, with lit control #20234 and dead control #8710 at the start and end of each pass. At base, registry.ts has 109 string sites holding 79 distinct unqualified numbers of 100 or more: 75 answer 200 and 4 answer 404, exactly #6345, #10926, #10329, #14676. At head: 105 string sites, 75 numbers, all 200. Controls 4/4 and 4/4 each pass.The gate's census (
node scripts/check-issue-citations.mjs --census --json, board enumerated in full):Repo-wide allocated-but-absent goes 1222 to 1195. That moved with
main's merged commits, not with this diff.Hypothesis falsified: neither count moves, by construction. The citation gate reads source through the comment-prose projection, which blanks string literals, so these four sites were never in its census.
scripts/doc-authoring-prose-id.baseline.jsonexcludespackages/spec(PACKAGES_PROSE_EXCLUDED), andcheck:doc-authoring's spec leg sweeps message, strictObject, tombstone, describe and function-built positions, not a conversionsummary: it was green at base with all four numbers present. At head it prints "16827 customer-facing string(s) across 1186 spec sources clean" and "808 pinned site(s) across 229 file(s) ... no growth, no burn-down unrecorded".Residue. A scratch instrument over TypeScript 6.0.3 builds (a) the file with every comment token cut and everything else kept byte for byte and (b) the leaf-token stream, with the four
summaryinitializers masked by conversion id. Base vs head: IDENTICAL (residue sha256 prefix3352f29d13665120on both sides; 47,810 leaf tokens and 842 comment tokens cut on both). Controls mutate the head text in memory. A comment insertion stays IDENTICAL. Each of these DIFFERS: another summary literal edited, a template literal, a regex literal, an appended declaration, a masked conversion'sid, and itssurface(7/7). Unmasking the mongo summary alone DIFFERS (exit 1). The instrument evaluates each literal's value at base and at head: only the citation and the added clause differ. Line balance for registry.ts: +16/-11 (12,678 to 12,683 lines).Regeneration.
gen:spec-changesandgen:upgrade-guide, never by hand. Exactly 3 lines move, all #6345's copy:spec-changes.json:229 and :1121,docs/protocol-upgrade-guide.md:188. Word diff on each:used (#6345)becomesused, so the id that selects a driver and the id that selects its config contract are one string with no mapping between them.check:spec-changesandcheck:upgrade-guideexit 1 before regeneration and 0 after.Tests. Spec sources at
31a296909fare identical to head.os-verify-lock:turbo run build --concurrency=2over./packages/*and./packages/*/*, 71 of 71 (pre-merge and again at head).check:generated: all 15 generated artifacts are up to date.src/conversions src/migrations src/integration src/data, the translation and cron retirement files, the two step-18 merge scripts): 132 files, 4,732 passed.localproject: 575 files, 16,960 passed and 1 todo.repoproject: 40 of 44 files, 645 passed. The other four (build-schemas-check-mode,def-key-collisions,publish-smoke-boot-failure,publish-smoke-port-collision) hittimeout 560(exit 124). NOT MEASURED, left to CI. None reads summary text.pnpm --filter @objectstack/spec typecheck: exit 0.Gates at 7ec0ef4.
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commandsderives 78, the same list as before the merge. All 78 exit 0,check:issue-citations,check:doc-authoring,check:generatedandcheck:upgrade-guideamong them.--ranreports 78 derived, 78 run, 0 NOT-MEASURED, 0 UNRUN. Also run:check:spec-changesandcheck:authorable-surface, both exit 0.Lint, a proven narrowing.
eslint --no-inline-config --format jsonon registry.ts: 1 file, 0 errors, 0 warnings.isPathIgnoredis false.eslint.config.mjs:327-328states that type-aware linting is never enabled, so a text edit cannot move an untouched file's verdict. The repo-widepnpm lintis CI's run.Changeset.
patch, with a standaloneClause-②: noline.files[]shipsdistandspec-changes.json. Each new phrase is in 6 dist files, and the four old citation spellings are in 0. Control: the unchangedrateLimitConfigsummary is in 6.Merge probes. From a bare
--sharedclone with no merge driver, deleted afterwards:merge-treeof this head with #20637's branch heada2abb8c78aexits 0, and with #20662's head3fcedfb564exits 0.Acceptance notes
docs/protocol-upgrade-guide.md:68still carries cli/runtime: explicit driver(--database-driver/OS_DATABASE_DRIVER)在 CLI 与 standalone stack 之间仍有三处分叉(#6265 后续) #6345. It is the protocol-17 step rationale, generated frompackages/spec/src/migrations/registry.ts:343, so it moves with themigrations/stage (233 comment sites there per the census). Stage 8's record calls it hand-written, but it is generated.service-datasourceandmetadata-coresites of the same numbers (dead tracker citations in thedomain:clipackages (689 sites, 166 numbers, 95 files): the ruling C+D stage for this lane (from #20556) #20594 / dead tracker citations in thedomain:enginepackages (645 sites, 160 numbers, 104 files): the ruling C+D stage for this lane (from #20556) #20595's lanes), the test-file sites, and the liveness JSON notes stage 8 listed.check:doc-authoringreaches a conversionsummary, so a number that dies later in one goes unflagged. Noted, not filed: it is a gate's coverage boundary, not a defect class, and no new gate is proposed.#4911inconnector-rate-limit-config-removed, and ADR-0049 candidate:element:formdeclares a full form contract with no renderer registration found in objectstack/objectui #9249 kept here). Form D says anything an author is shown carries no number, which would reach them too. This stage removes dead citations only, as its claim requires. Whether live numbers in summaries become a later stage is the seat's call.Generated by Claude Code