docs(service-job): re-anchor the dead tracker citation to the commit that decided it - #20866
Merged
objectstack-fleet[bot] merged 1 commit intoSep 30, 2026
Merged
Conversation
…that decided it The inert cron fixture's docblock and the timeout suite's pointer to it cited a tracker number that no longer resolves. Both now cite commit 226cb71, which moved every exact-count case onto the shared NEVER_FIRES fixture and whose message records the Date-only measurement the fixture's docblock describes. Comments only; line counts kept. Claude-Session: https://claude.ai/code/session_01XY5uCwTjZj7884yYtyur4H Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift Check
What this run could not see
Coarse fallback — 3 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
objectstack-fleet
Bot
deleted the
claude/issue-20596-service-job-citations
branch
September 30, 2026 14:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #20596
Clause-②: no
What changed
This is the seventeenth stage of the
domain:serviceslane of the dead-citation sweep. It coverspackages/services/service-job/src/**and nothing else. By the seat's claim (5911377566), it is the next of the two single-site packages left in the lane, taken one package per stage. Later stages cover the other packages, so this PR saysPart ofand the card stays open.Every comment or docblock site in scope that cited a tracker number answering 404 has been rewritten in ruling C+D's form C (comment 5749154545 on #19123), by the method of stages 1 to 16 (the latest is PR #20850, landed as
40d6c5fbd, the base here). That is 2 sites on 2 lines in 2 files, covering 1 number:src/never-fires.fixture.ts:30, the census's one site in this package at the base (a docblock);src/db-job-adapter.timeout.test.ts:55, a test-comment site the census defers, found by the supplementary reading below and rewritten too, as stages 1 to 15 did.No test string, source string or gate-invisible spelling in this package carries a dead number, so these two sites are the whole population.
Both rewritten lines now cite the commit in this repository that decided what they describe: 1 commit sha. No ADR or ruling record records that decision (see the per-number table), so ruling C's commit rung applies. No number was dropped.
Only comments changed. Each file keeps its line count (2 lines out, 2 in), so no line citation into either file moves. No code token moves (see the guard below). No citation number is added: the only tracker number on the added lines is the live
#8628, which already stood on its line.No changeset. Neither rewritten line reaches
dist, anddistis byte-identical with and without the rewrite (see Changeset below), so this PR takesskip-changeset.Census:
service-job, before and afterInstrument (A1). The gate's own
node scripts/check-issue-citations.mjs --census --json, read-only and unchanged. The count below is itsallocated-but-absentfindings underpackages/services/service-job/. Each run counts as a reading only because its board frontier equals the newest issue or pull-request number, read by a separate request just before and just after the run.allocated-but-absent40d6c5fbd, run 2026-09-30T12:36:32Z to 12:40:56Z6ac866f86, run 12:46:10Z to 12:49:55ZThe whole-repo drop is 1, and the finding sets of the two runs differ by exactly one row,
never-fires.fixture.ts:30 #8748, removed; none was added. Theresolvestally is 33,221 in both runs, andresolves-as-pull-request(1,985) andcross-repo-unjudged(1,018) did not move either. Neither run was truncated or discarded: both enumerations read 187 pages at the newest frontier. The seat's census counted 1 here at6bff748b, and the base agrees:6bff748bis an ancestor of the base, and no commit between them touches this package'ssrc.Supplementary instrument, the whole scope. The census does not read test files or strings. So a second reading runs the gate's own exported
extractCitations(whole-file and comment-prose projections) andnamesThisRepositoryover every.tsfile underservice-job/src(18 files). It takes its verdicts from the before census's own board reading rather than from a second enumeration: a number is dead when that census reported itallocated-but-absent, and alive when the gate's own census-scope extraction (collectCitations) judged it and the census did not report it. 4 numbers are covered by neither, because they stand only in test files. Each was read on its own through the read-only tools, and each answers as an issue:#8628,#9611,#9631and#9633. The probe's control:#8748answers 404 on the issues endpoint and on the pull-request endpoint.40d6c5fbd6ac866f86Its src-comment column equals the census's 1, which is the control on the second instrument. The 93 live citations are the same in both readings (81 by the census's judgement, 12 by the single reads), none is cross-repo, none is unjudged, and the drop of 2 citations is exactly the two rewritten sites. A third, raw reading (every
#followed by 2 to 6 digits, whatever surrounds it) finds 95 occurrences before and 93 after, the same drop of 2, and no token beyond the gate's grammar.Per-number table
Sites and files count every dead occurrence in scope at the base (comments and strings, tests included).
#8748226cb71d5(PR #8774): every exact-count case in this package moves onto the inertNEVER_FIREScron fixture ('0 0 30 2 *', February 30th, which never occurs), and the fixture moves out of the timeout suite into the sharednever-fires.fixture.ts. Its message records the measurement:30describes: onlyDatefaked, the registration placed 2/5/10/15 ms before the expression's instant, one extra handler run per case under the firing spellings, and two of the three no longer reproducing at a 2 ms lead. That is what:30says, and what:55's 「now shared with the sibling job suites rather than spelled a second time here」 says. Its subject names#8748, and its own diff names it on 2 added lines;git blameputs both rewritten lines in this commitThe sha matches exactly one commit (
git rev-parse --disambiguate, count 1) and is an ancestor of the base (merge-base --is-ancestor, exit 0; reverse leg, base against the anchor, exit 1; control legs exit 0:7246d631d, 5,451 commits behind the base, and the repository's root commit1598cabe4, 15,209 behind, against the anchor's 5,436; the history is complete,--is-shallow-repositoryfalse, 15,210 commits at the base).#8748answers 404 on the issues endpoint and on the pull-request endpoint, read one by one.No ADR,
scripts/adr-anchors/file or ruling record names#8748, PR #8774,NEVER_FIRES,never-fires, February 30th or an inert cron (git grepoverdocs/adrandscripts/adr-anchors: 0 hits), so ruling C's first rung is empty. The repository's other#8748tokens areobjectui#8748, a cross-repo reference the gate never judges.Wordings to check
never-fires.fixture.ts:30, tag swap in place. 「Measured (service-job:cron-job-adapter.test.tscarries the same minute-boundary self-fire hazard fixed in #8628 — four cases register a real every-minute cron and assert exact counts #8748) by faking ONLYDate」 became 「Measured (commit 226cb71) by faking ONLYDate」. The form is the onepackages/lint/src/lint-flow-patterns.ts:1468already carries onmain(「Measured (commit 8ed9c54)」).db-job-adapter.timeout.test.ts:55, tag swap in place. 「(service-job:db-job-adapter.timeout.test.tsreds CI whenever the run crosses a minute boundary — it registers a real every-minute cron and asserts exactly one run row #8628, service-job:cron-job-adapter.test.tscarries the same minute-boundary self-fire hazard fixed in #8628 — four cases register a real every-minute cron and assert exact counts #8748)」 became 「(service-job:db-job-adapter.timeout.test.tsreds CI whenever the run crosses a minute boundary — it registers a real every-minute cron and asserts exactly one run row #8628, commit 226cb71)」. The live#8628stays: it is the report of the wall-clock flake, whose own change,7246d631d(PR test(service-job): make the timeout suite's cron unable to self-fire #8750), first made this suite's cron unable to self-fire. The form is the one stages 7 and 9 landed (for example(#5928, commit 69787f07b)inplugin-audit).eslint.config.mjsdeclares no line-length rule, and reflowing would have moved neighbouring lines.Sites left
src: none. No test title, assertion message, operator log string, runtime refusal, quoted maintainer ruling or generated file in this package carries a dead number.src, listed and left, not edited in this stage:CHANGELOG.mdnames the dead#13112on 1 line (:705; 404 on the issue and pull-request endpoints). Its other 27 numbers are live: 19 by the census's judgement, and by single reads#18715,#14619,#9517,#1893,#9611,#9631and#9633as issues and#9546as a pull request.vitest.config.tsnames the live#10374.README.md,package.jsonandtsconfig.jsonname none.Mechanical guard: no code token moves
The guard compares, base
40d6c5fbdagainst head, over both touched.tsfiles:forEachChildwalk, so comments are trivia and JSDoc nodes are never visited). String and template literals are therefore read in full.getChildrenwalk, so punctuation and keywords are included; JSDoc nodes skipped).Results:
6ac866f86: 755 base leaf tokens, 0 files with a token change on either reading (exit 0).expression: NEVER_FIRES }toexpression: NEVER_FIRESX }): DIFFER on the identifier in both readings (exit 1).'0 0 30 2 *'to'0 0 31 2 *'): DIFFER on the string literal in both readings (exit 1).TIMEOUT_MS = 20to21): DIFFER on the literal in both readings (exit 1).Every mutation went through
scripts/ablation-replace.mjs(wrap mode) under a shell trap that restores by absolute path, and each landed (anchor 1 to 0, blob changed). Each restore was proven byte-identical to the HEAD blobs (1fd5e1b3f612,ce37b1050c78), withgit diff HEADempty and a clean tree afterwards.Changeset: none (
skip-changeset)files[]isdist,README.mdandCHANGELOG.md, and the package is not private.never-fires.fixture.tsis a test-only support module (nothing insrc/index.tsre-exports it, and the tsup entry issrc/index.tsalone), and the other touched file is a test. Measured on the built package (A3), afterpnpm --filter '@objectstack/service-job...' buildat6ac866f86, where the package's owntsupran and cleaned its output folder:distfile (0 in all 6, source maps included). Nor do the old number,#8628, the anchor sha, the neighbouring lines:28,:31,:54and:56,NEVER_FIRES, the'0 0 30 2 *'expression, or a never-written negative phrase.CronJobAdapter(45 hits),DbJobAdapter(73) andsys_job_run(52) across the entries, and two docblock lines of theDbJobAdapterclass JSDoc indb-job-adapter.ts(「{@link DbJobAdapterOptions.recordRuns}isfalse, the on/off switch for」 and therecordRunsgating line below it), each inindex.d.tsandindex.d.cts.scripts/ablation-replace.mjslegs, with each file proven equal to its base blob,919a2e444f23andeb00f6eb1978, during the leg), and again after the proven restore. The sha256 of all 6distfiles is identical in all three builds: JS entries, declaration files and source maps.So nothing this PR rewrites is published, and a changeset would announce a change no consumer can observe. No
.changeset/*file is added or touched.Gates (head
6ac866f86)node scripts/check-issue-citations.mjsexits 0 (「no issue citations added against 40d6c5f」).pnpm check:issue-citationsexits 0 (self-test, 114 cases, 8 batteries).pnpm check:doc-authoringexits 0 (the sibling-package prose-id baseline holds, no growth).node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackat6ac866f86(change set derived from git: 2 paths against the merge base40d6c5fbd) derived 54 commands, all among the dispatch list's 63.--ran, fed each command with its exit code, reports 54 derived, 54 run, 0 NOT MEASURED (a derived zero), 0 unrun, and exits 0. Of the other 9, it classifies 7 as pending-changeset families and 2 as outside this derivation.turbo run buildover./packages/*and./packages/*/*ran first under the shared verify lock (71 of 71 tasks), so no gate hit an unbuilt workspace.pnpm check:authz-resolver,pnpm check:error-code-casingandpnpm check:filter-alias-parity, plusnode scripts/check-changeset-fixed.mjs, which the dispatch named. Each exits 0.6ac866f86:pnpm --filter @objectstack/service-job test: 11 files pass and 117 tests pass, which is every tracked test file undersrc/.pnpm --filter @objectstack/service-job typecheckexits 0, andtsc --noEmit --listFilesputs both touched files in the program (the config includessrcand excludes no test file)..tsfiles, gives 2 files, 0 errors and 0 warnings (its--format jsonoutput). Both files are in eslint's own population (not reported ignored;dist/index.js, the control, reads ignored).eslint.config.mjsnever enables type-aware linting (noparserOptions.project, as its own lines 327-328 state), so a comment edit here cannot move the verdict on any untouched file. The repo-widepnpm lintis CI's run.pnpm check:nul-bytesexits 0, and a raw scan of the changed files for control bytes finds none.Acceptance notes
CITATION_RErefuses a hyphen after the digits, so a dead#N-wordcitation (#13398-class) is invisible to the diff gate and to the census #20636, including theclause #Nposition). At the base and at the head,#N-word,#A/#B,option #N,clause #Nand URL-spelled links are each on 0 lines, so the claim's 0 / 0 / 0 / 0 / 0 hold. The one prefix-joined token,pre-#6617in a test title ofdb-job-adapter.degraded-outcome.test.ts, is inside the gate's grammar and names a live number.service-job/src. It carries no number, neither instrument sees it, and this diff removes no antecedent.srcresidue.CHANGELOG.md:705names the dead#13112; the file is release-owned and is left.mainat40d6c5fbd.mainhas since moved two commits (to660a9b247). Neither touchespackages/services/service-job,scripts/check-issue-citations.mjs,scripts/pm/dispatch-gates.mjsor.changeset/config.json, so no merge was taken; the merge queue rebuilds on the merged generation. The one derivation input that moved isscripts/doc-authoring-prose-id.baseline.json, where the second commit removed onlypackages/objectqlentries; this package has no entry there before or after, so the merged tree cannot move that gate's verdict on this diff.Generated by Claude Code