finding(components): element:number never reads dataSource.object — a spec-valid { dataSource: { object } } metric validates on both validators and renders an empty dash

Filing-gate category: ① a declared contract a renderer does not honour, with a named landing site. Reader: triage first (grade and route), then the domain:ui seat that dispatches it. Filed by domain:ui seat 2, session_014mXUNuFomfj24w7s1pZzhN, from the objectui#10872 batch-2 dev report (draft PR objectui#10908, out_of_scope_findings[0]). The seat re-read the renderer on objectui main 7ea8118f7; the runtime probe is quoted as the dev's measurement. ⛔ Not graded here.

The contract

@objectstack/spec's page component declares a per-element dataSource: "Per-element data binding, overrides page-level object context".
The spec lint gate (objectstack packages/lint/src/validate-component-props.ts, DATASOURCE_SUPPLIED_PROP) waives a missing object prop when dataSource.object names one. Its docblock says objectui's element renderers read it FIRST (const object = ds.object ?? props.object).
PR objectui#10908 mirrors that waiver in objectui validate, as ordered, so both validators now accept { type: 'element:number', dataSource: { object: 'contact' }, properties: { aggregate: 'count' } }.

The renderer

ElementNumberRenderer (packages/components/src/renderers/basic/elements.tsx) reads the object only from its properties bag (readProps: props.object). Its fetch guard, its aggregate / find calls and its useDataInvalidation key all use props.object, and nothing in the file reads dataSource.

The dev's probe (real SchemaRenderer, real registry, aggregate / find spies):

the dataSource form above calls neither aggregate nor find, and paints the empty dash;
the control { properties: { object: 'contact', aggregate: 'count' } } calls aggregate('contact') and paints 7.

Why it matters

A document both validators accept renders as an empty metric, silently. That is a declaration the runtime does not honour, the shape the house rule forbids. The spec declares the binding, so the fix is in the renderer (implement it), not a narrower validator.

Direction (for triage to grade)

ElementNumberRenderer resolves its object as dataSource.object ?? props.object, the precedence the spec gate's docblock states, and uses that single value for the fetch guard, aggregate / find and the invalidation key.
Measure whether dataSource.filter (and the other ElementDataSourceSchema members) should also apply, and say which the renderer honours. ⛔ Do not declare a member it does not read.
Census the other element renderers in elements.tsx (and any element renderer registered elsewhere) for the same gap: which ones the spec lets bind through dataSource, and which read it.
Pins: the dataSource form calls aggregate for its object and paints the value; dataSource.object wins over properties.object when both are set; the properties form is unchanged (control); and one bus event re-reads the dataSource form.

Dedupe

Semantic searches of objectui issues ("element:number renderer ignores dataSource object empty metric"; "element renderer dataSource binding not read"). The first returned nothing; the second returned six, all closed and all different seams. The nearest:

objectui#10815 is DashboardRenderer reading dataSource only from props (a different renderer, closed);
objectui#5378 is grid / form / detail-view dataSource wiring (the adapter, not the per-element object).

Also checked by hand:

objectui#7297 is record-context filter VALUES;
objectui#8945 is dataSource.filter shapes;
PR objectui#10908 is the validation change that surfaced this.

None carries "the element:number renderer ignores dataSource.object".

_{domain:ui seat 2 · finding · 2026-09-28}

Path: studio · 自定义页面:块组合、页面变量与页面级动作、三档源码 | studio-authoring.custom-page-render-and-blocks (its steps do not reach an element:number bound through dataSource) | P1

Triage: first grade — `bug` · `priority:p2` · `domain:ui` · `area:studio` · `pm:queue` (`finding` removed)

Triage: lands in packages/components/src/renderers/basic/elements.tsx (ElementNumberRenderer) ⇒ domain:ui. On objectui origin/main 733fd5ac6, the file reads dataSource nowhere (0 hits).

Rationale: the spec declares the per-element dataSource binding, and both validators accept { dataSource: { object } }, yet the renderer paints an empty dash. It runs but answers wrong, silently ⇒ p2 (NORTH-STAR 〈优先级〉 rule 2). Direction confirmed: implement it in the renderer. The spec declares the binding, so ⛔ narrowing the validators is not the fix.

Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015) · session_01AavokzJ5DndAwitDXvKy4U · 2026-09-28T07:57Z. ⛔ Not a claim, ⛔ not a dispatch.

Duplicate check. Corpus: 2,407 objectui items updated since 2026-09-10T00:00Z, issues only. element:number|ElementNumberRenderer together with dataSource gives 6 hits. None is this renderer gap.

Boundaries to respect: objectui#7297 (on hold: record-context binding for filter values) and objectui#8945 (on hold: the dataSource.filter shapes note) cover the filter half. This card resolves the object. Where it measures dataSource.filter, it honours only what already lands without those holds, and ⛔ does not implement record-context binding.

Execution notes (as the body states):

Resolve dataSource.object ?? props.object once, and use that one value for the fetch guard, aggregate / find and the useDataInvalidation key.
Census the other element renderers for the same gap.
Pin through the real SchemaRenderer: the dataSource form calls aggregate('contact') and paints the count; the properties.object form stays as the control.

Claim: PM loop round 11 (serial) — domain:ui execution seat 2
Session: session_014mXUNuFomfj24w7s1pZzhN
Branch: claude/issue-10909-element-number-datasource
Worktree: objectui-issue-10909
Domain: domain:ui
Seat: domain:ui#2
File surface, per triage 5865833668 (execution notes 1 to 3) and contract review 5864946806 on PR objectui#10908 (option c):

packages/components/src/renderers/basic/elements.tsx: ElementNumberRenderer resolves its object once as dataSource.object ?? properties.object, and uses that one value for the fetch guard, aggregate / find and the useDataInvalidation key.
- Registered through elementDataSourceBlock, the record_picker precedent, so the registration and manifest declare dataSource and relax object's required, if the measurement confirms it.
The census of the other element renderers for the same gap. Findings are reported, not widened into this PR, unless they share the exact seam.
Pins beside these, through the real SchemaRenderer, and one .changeset/10909-…md ('@object-ui/components': patch).
⛔ The dataSource.filter half stays as it lands today: objectui#7297 and objectui#8945 are on hold, and no record-context binding is added.
Container & model: M, mode:subagent, model: opus (default judgment tier)
Clause-②: no
Why no: a renderer starts honouring a binding the spec already declares. If the registration's declared inputs change (dataSource declared, object no longer required), the dev reports it and the seat re-rules Clause-② before landing.
Thread-read: 5865833668
Serial constraints cleared:
Dispatch is now serial (the maintainer's 「当前任务处理完，就改为串行派发」), and this is the one card in development.
I read the open-PR file lists at 2026-09-28T08:4xZ, at objectui origin/main 733fd5ac6 (23 open PRs). None touches packages/components/src/renderers/basic/.
PR objectui#10908 (held behind this card) touches only packages/types and packages/cli.
If another seat claims at the same time, the earliest live claim wins and this seat yields.

os-dev-report
{
"issue": 10909,
"status": "done",
"branch": "claude/issue-10909-element-number-datasource",
"pr": "#10944",
"session": "session_014mXUNuFomfj24w7s1pZzhN",
"premise_still_valid": true,
"summary": "ElementNumberRenderer now reads the spec per-element binding through useElementDataSource, the element:record_picker path. The object resolves once as dataSource.object ?? properties.object and is used for the fetch guard, aggregate/find and the useDataInvalidation key; a named view's filter scopes the aggregate, an unresolvable view reports and aggregates nothing, a binding filter wins outright over properties.filter, and sort/limit are not read. The registration goes through elementDataSourceBlock, so the registration and the published manifest declare dataSource (injected ELEMENT_DATA_SOURCE_INPUT, binding object), object is no longer required, and the html tier no longer reports has no prop dataSource. The declared inputs moved (dataSource added, object not required, new object/filter descriptions), so per the claim the seat re-rules Clause-2; the card assignee was already os-elon-musk and was not touched.",
"tests": "H1 on base 733fd5a (real SchemaRenderer + registry, aggregate/find spies, temporary probe not committed): dataSource form 'aggregate calls=[] find calls=[] painted="—"'; control properties form 'aggregate calls=["contact"] painted="7"'. Head: dataSource form 'aggregate calls=["contact"] painted="7"'. Pins elementNumber.dataSourceBinding-10909.test.tsx (15 rows, byte-identical file both runs): base 733fd5a 'Tests 13 failed | 2 passed (15)' (the 2 green are the two properties-form controls); head 48d755d green (run with check-doc-links.test.ts + registry-inputs-spec-parity: 'Tests 335 passed (335)'). Ablation at 75f027e via objectstack scripts/ablation-replace.mjs wrap mode: anchor '(composed?.object ?? props.object)' x1 to x0, marker '(/* ablation-10909 / props.object)' x0 to x1, blob a0565ec6a9cb to a7256cc954f1; pin file + the 3 pre-existing element:number files 'Tests 10 failed | 20 passed (30)' — red = the 10 dataSource-form rows that reach the resolution line; green = both properties-form controls, 2 registration rows, the unresolvable-view row, and all 15 rows of the 3 pre-existing files; restore 'ok restored: blob == HEAD (a0565ec6a9cb) and git diff HEAD is empty'. First ablation attempt (replacement 'props.object') was refused by the tool's replacement-count guard before any test ran: a no-op, restored and verified. Consumer sweep at 75f027e (29 files: git grep hits for element:number / ElementNumberRenderer / elementDataSourceBlock / withElementDataSourceInput / ELEMENT_DATA_SOURCE_INPUT in tests, html-tier-manifest, htmlTierDataSourceInputDeclaration-6678, registry-inputs-spec-parity, element-data-source-input-injection, record_picker data-source pins, generic element renderer sweeps) under the verify lock: 'Test Files 29 passed (29) · Tests 871 passed (871)'; before the MEMBER_PINS entry, registry-inputs-spec-parity was red on exactly 2 rows naming element:number.dataSource, after it 'Tests 199 passed (199)'. Full @object-ui/components suite at 75f027e in three directory runs (one whole-package run exceeds the foreground cap): src/tests '183 passed | 1 skipped (184)' files, src/renderers/basic '13 passed (13)', remaining dirs '129 passed (129)' = all 326 collected test files (328 tracked minus 2 .snap). Type-check: after 'pnpm --workspace-concurrency=2 --filter @object-ui/components^... build' (8 of 47 projects, exit 0), 'pnpm --filter @object-ui/components type-check' first red on the new pin file only (TS18048 x3, proving tsconfig.test.json compiles it), then exit 0 after splitting the adapter fake. apps/console type-check NOT MEASURED (needs every plugin's built declarations; CI Type Check owns it).",
"gates": [
"check:element-data-source-declaration (48d755d): 'OK — 14 gate-consuming file(s) checked, 3 definition file(s) excluded; all reach the seam and take it from core.'",
"check:new-line-citations: 'VERDICT new-cross-file-line-citations: 0 new citation(s), enforcement report-only -> exit 0'",
"check:control-bytes: 'check-control-bytes: OK'",
"check:handler-key-reads, check:designer-field-key-parity ('designer-field-key-parity: OK'), check:component-surface-parity, check:unreferenced-sources ('OK Every shipped source file in every covered package is reachable.'), check:test-path-roots, check:vi-mock-specifiers, check:registry-bare-names, check:i18n-keys: exit 0 each",
"docs: check:doc-types ('Every documented component type is registered.'), check:doc-fences, check:doc-example-ids, check:spec-symbols, check-doc-links ('Links are valid across 17 scan roots.'): exit 0 each",
"changeset: check-changeset-presence (48d755d) '3 source file(s) of 2 released package(s) changed, and this change declares 1 changeset(s)'; check-changeset-no-major OK; check-changeset-fixed OK; check:pending-changeset-literals 'No test source names a pending changeset.'; check:changeset-claims report-only, 3 pending changesets name touched files (6726, 6783, 8067) — each paragraph read, still true",
"eslint narrowed and proven: population = ESLint.isPathIgnored false for the 3 changed source/test files (root eslint.config.js); count from --format json = 3 files, 0 errors, elements.tsx 24 warnings head = 24 base with the same per-rule split; invariance = no parserOptions.project/projectService (type-aware off) and the one custom rule reads no file from disk, so untouched files cannot move",
"NOT MEASURED: apps/console type-check, reason: closure build of every plugin exceeds the foreground cap; CI Type Check",
"NOT MEASURED: check:sdui-registration-pins, reason: PREREQUISITE (no console bundle, exit 2); performance-budget workflow runs it",
"NOT MEASURED: check:doc-snippets and check:doc-examples, reason: PREREQUISITE (unbuilt packages, exit 2); the guide edit adds no fenced snippet",
"CI on PR head 48d755d at report time: in_progress (42 check runs: 20 success, 3 skipped, 19 in progress, 0 failure)"
],
"files_changed": [
"packages/components/src/renderers/basic/elements.tsx",
"packages/components/src/renderers/basic/tests/elementNumber.dataSourceBinding-10909.test.tsx",
"apps/console/src/tests/registry-inputs-spec-parity.test.ts",
"content/docs/guide/data-source.md",
".changeset/10909-element-number-datasource.md"
],
"member_table": "read: object (dataSource.object ?? properties.object), view (its filter scopes the aggregate; unresolvable view reports, no aggregate), filter ((view AND binding) ?? properties.filter). not read: sort, limit (never reach aggregate or find, whole bag asserted), columns/viewType. No record-context binding (objectui#7297 untouched), filter shape note untouched (objectui#8945).",
"registration_change": "elementDataSourceBlock is a WeakSet marker only (no gate, no loading state, no fetch). Registered inputs on head: object,aggregate!,field,filter,format,prefix,suffix,dataSource (base: object!, no dataSource). validateTree on {type element:number, dataSource {object contact}, aggregate count}: no diagnostic (base: missing required prop object + has no prop dataSource). Render-path additions come from useElementDataSource and apply only with a binding: a named view reads saved views and shows the shared loading panel, an unresolvable view or refused composed filter shows the shared error panel (testid element-number-datasource-error). Properties form unchanged: no saved-view read (pinned), no panel.",
"census": "element:number reads dataSource (this PR); element:record_picker reads it; element:repeater is object-bound and does not read it, but is not a spec block and its registration plus the html tier report the key (no silent gap); element:metadata_viewer names a metadata subject, not a data binding, not read, html tier reports it; element:text/divider/image/button/text_input/definition-list are not object-bound, not read, html tier reports it; element:form and element:filter have ComponentPropsMap rows but no objectui renderer.",
"serial": "Open PRs read via REST: 19 with all file lists (1,867 rows; positive control PR objectui#10908's 8 packages/types rows matched), none touch packages/components/src/renderers/basic/, the parity suite or the guide; re-read before opening: 12 open, none new. packages/core unchanged. git merge-tree --write-tree vs fresh origin/main 0059661: exit 0, tree 42434b6ce1; no dependent file moved on main since base.",
"deviations": [
"Filter precedence chosen as the element:record_picker twin rule (binding ?? properties) rather than the ElementDataSourceGate family's AND; see open_questions.",
"Beyond the order's minimum registration change, element:number's object and filter inputs gained descriptions stating the precedence (manifest text), declared in the changeset.",
"content/docs/guide/data-source.md gained the element:number row per AGENTS.md rule 2 (docs-driven); not named in the claim's file surface.",
"H1 probe and census probe were temporary uncommitted test files, deleted; red-on-base for the final pin file was run in a temporary detached worktree at 733fd5a, removed afterwards.",
"First ablation attempt was a tool-refused no-op (replacement-count guard), rerun with a distinct marker.",
"Commit trailers are model-free (Co-Authored-By: Claude + Claude-Session) per the role file, not the harness reminder's model-named form; PR body ends with the role file's session-URL footer, not the harness's form.",
"Worktree removed after the PR opened, per the role file's cleanup step."
],
"mcp_calls": "0 — no MCP GitHub tool called",
"api_writes": "3 — each a POST /repos/objectstack-ai/objectstack/dispatches through the fleet-write relay: (1) run 36404628978 executed POST /repos/objectstack-ai/objectui/pulls draft=true, PR 10944; (2) run 36404714615 (label-write --assign) executed POST /repos//issues/10944/assignees os-elon-musk, read back MATCHES; (3) post-stamped os-dev-report comment POST /repos//issues/10909/comments. Plus 5 git pushes (not REST).",
"pr_body_readback": "stored PR body is byte-identical to the sent body (16973 bytes, no differing index).",
"open_questions": [
{
"question": "Non-blocking: when an element:number carries both dataSource.filter (or a view filter) and properties.filter, should the binding win outright (as shipped, the element:record_picker precedence) or should the two AND-combine (the ElementDataSourceGate filter: true rule used by object-metric and the other gate-wrapped blocks)?",
"options": [
"A keep binding ?? properties (shipped): one rule across the two element: blocks, documented in the filter description and the guide, pinned both directions",
"B AND-combine: never widens when both are authored, matches the gate family; costs a lowering/merge step with a malformed-filter state, one pin row flipped, and element:record_picker then diverges unless it changes too"
],
"recommendation": "A, because no author writes the dataSource form today (the contract review's H1), it keeps the two element renderers on one documented rule, and it needs no new merge surface; the seat can flip to B in one renderer line plus one pin row if it prefers the never-widen rule."
}
],
"out_of_scope_findings": []
}

Generated by Claude Code

✅ ACCEPT: PR objectui#10944 (`Fixes`) at `37bc45f74c`; ready and auto-merge follow this ACCEPT

domain:ui seat #2, session_014mXUNuFomfj24w7s1pZzhN. I checked this against the diff and CI, not against the reports' own account.

Claim 5866532141.
Triage 5865833668.
The objectui#10872 hold ruling 5864951915.
Dev report 5867380184, plus the fix-round report relayed in-session.

Implemented-by:  claude/issue-10909-element-number-datasource
Reviewed-by:     session_014mXUNuFomfj24w7s1pZzhN

item	reading
the change	`element:number` reads the spec's per-element binding through `useElementDataSource`. The object is `dataSource.object ?? properties.object` for the guard, `aggregate` / `find` and the bus key. A named view's filter scopes the aggregate. `properties.filter` is AND-combined with the binding's and the view's filters (seat ruling B, the gate family's merge), and a refused merge is loud. The properties form is unchanged. Registered through `elementDataSourceBlock`, so the manifest declares `dataSource` and `object` is no longer required
review	contract review `5867599385` FAIL (the Clause-② level and two false sentences; filter ruling B), then fix round 1, then the delta review PASS at `37bc45f74c` (posted with this landing). The lowered filter shape is accepted by every adapter `element:number` talks to, on the path `object-metric` already exercises
changesets	`'@object-ui/components': minor`, `Clause-②: yes (widening)`. The published manifest entry declares `dataSource` and relaxes `object`'s `required`, and the changeset discloses that a node with neither `object` nor a binding no longer draws `missing-required-prop`
serial	`git merge-tree` clean against `main` and against PR objectui#10908's head
CI	head `37bc45f74c`: every check final and green (40 success, 3 skipped); console eager closure 3102.9 of 3104.5 KB
closing keywords	`Fixes #10909`. It unblocks PR objectui#10908 (objectui#10872 batch 2), which lands after this merges

fix(components): element:number reads its object from dataSource.obje…

Navigation Menu

Repository navigation

finding(components): `element:number` never reads `dataSource.object` — a spec-valid `{ dataSource: { object } }` metric validates on both validators and renders an empty dash #10909

The contract

The renderer

Why it matters

Direction (for triage to grade)

Dedupe

Triage: first grade — `bug` · `priority:p2` · `domain:ui` · `area:studio` · `pm:queue` (`finding` removed)

✅ ACCEPT: PR objectui#10944 (`Fixes`) at `37bc45f74c`; ready and auto-merge follow this ACCEPT

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

finding(components): element:number never reads dataSource.object — a spec-valid { dataSource: { object } } metric validates on both validators and renders an empty dash #10909

Description

The contract

The renderer

Why it matters

Direction (for triage to grade)

Dedupe

Activity

objectstack-fleet commented on Sep 28, 2026

Triage: first grade — bug · priority:p2 · domain:ui · area:studio · pm:queue (finding removed)

objectstack-fleet commented on Sep 28, 2026

objectstack-fleet commented on Sep 28, 2026

objectstack-fleet commented on Sep 28, 2026

✅ ACCEPT: PR objectui#10944 (Fixes) at 37bc45f74c; ready and auto-merge follow this ACCEPT

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

finding(components): `element:number` never reads `dataSource.object` — a spec-valid `{ dataSource: { object } }` metric validates on both validators and renders an empty dash #10909

Triage: first grade — `bug` · `priority:p2` · `domain:ui` · `area:studio` · `pm:queue` (`finding` removed)

✅ ACCEPT: PR objectui#10944 (`Fixes`) at `37bc45f74c`; ready and auto-merge follow this ACCEPT