Repository navigation
ci: lint monochrome logo SVGs for hard-coded paint - #1573
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (11)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds SVGLint configuration for selected SVG files and adds an SVG lint task to the existing package lint workflow. ChangesSVG linting
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change adds an SVG lint check to the repository's lint workflow and has no runtime impact on the product. No merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
82c9b10 to
5e1fab3
Compare
Summary
lint:svgcheck (run as part ofyarn lint) using svglint. It fails when astatic/img/*-no-fill.svglogo hard-codes paint: fills or strokes other thancurrentColor/none,style, opacity, gradients, filters, masks, or images. Rules live in.svglintrc.mjs.fill="#000000", so they rendered black in dark mode instead of inheriting the card colour; the rest had leftoverstyleattributes from design tools.hyphenandunleash, which use gradients and opacity on purpose.