Skip to content

ci: lint monochrome logo SVGs for hard-coded paint - #1573

Merged
jonathannorris merged 3 commits into
mainfrom
ci/svg-logo-lint
Oct 6, 2026
Merged

jonathannorris merged 3 commits into
mainfrom
ci/svg-logo-lint

Conversation

@jonathannorris

@jonathannorris jonathannorris commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Adds a lint:svg check (run as part of yarn lint) using svglint. It fails when a static/img/*-no-fill.svg logo hard-codes paint: fills or strokes other than currentColor/none, style, opacity, gradients, filters, masks, or images. Rules live in .svglintrc.mjs.
  • Fixes the 10 existing logos that fail it. Most hard-coded fill="#000000", so they rendered black in dark mode instead of inheriting the card colour; the rest had leftover style attributes from design tools.
  • Allowlists hyphen and unleash, which use gradients and opacity on purpose.

Comment thread scripts/lint-svg-logos.ts Fixed
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c3d7d93-ee9e-427f-9877-4f7a1994a7de
📥 Commits

Reviewing files that changed from the base of the PR and between cded826 and 5e1fab3.

⛔ Files ignored due to path filters (11)
  • static/img/abtasty-no-fill.svg is excluded by !**/*.svg
  • static/img/aws-no-fill.svg is excluded by !**/*.svg
  • static/img/config-cat-no-fill.svg is excluded by !**/*.svg
  • static/img/configdirector-no-fill.svg is excluded by !**/*.svg
  • static/img/cpp-no-fill.svg is excluded by !**/*.svg
  • static/img/dropwizard-no-fill.svg is excluded by !**/*.svg
  • static/img/harness-no-fill.svg is excluded by !**/*.svg
  • static/img/kotlin-no-fill.svg is excluded by !**/*.svg
  • static/img/otel-no-fill.svg is excluded by !**/*.svg
  • static/img/rust-no-fill.svg is excluded by !**/*.svg
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .svglintrc.mjs
  • package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds SVGLint configuration for selected SVG files and adds an SVG lint task to the existing package lint workflow.

Changes

SVG linting

Layer / File(s) Summary
SVG lint rules
.svglintrc.mjs
The configuration enables validity checks, sets rules for optional fill, stroke, and href attributes, and excludes two SVG files.
Lint task integration
package.json
Adds SVGLint as a development dependency and configures a Wireit task to lint selected SVG files. The existing lint task now depends on lint:svg.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: aepfli

Merge Risk: ⚪ Minimal · up to 5e1fa

This change adds an SVG lint check to the repository's lint workflow and has no runtime impact on the product. No merge-blocking risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 5e1fa

The change affects 1 system.

Changed systems: package.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — package.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in package.json: Adds the lint:svg package script, routed through Wireit.
  • observed — Modified behavior in package.json: Adds svglint version 4.2.1 as a development dependency.
  • observed — Modified behavior in package.json: Adds lint:svg to the dependencies of the existing lint task; it previously depended only on lint:es and lint:md.
  • observed — Modified behavior in package.json: Adds the lint:svg Wireit task, invoking svglint --ci for static/img/*-no-fill.svg and tracking those SVG files and .svglintrc.mjs as inputs, with no declared outputs.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI check for hard-coded paint in monochrome logo SVGs, which is the main change.
Description check ✅ Passed The description explains the SVG lint check, its rules, the fixes to existing logos, and the intentional allowlist entries.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openfeature ready!

Name Link
🔨 Latest commit 5e1fab3
🔍 Latest deploy log https://app.netlify.com/projects/openfeature/deploys/6ac3c5dbb5977f0009275de7
😎 Deploy Preview https://deploy-preview-1573--openfeature.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris
jonathannorris marked this pull request as ready for review October 5, 2026 15:45
@jonathannorris
jonathannorris requested review from a team as code owners October 5, 2026 15:45
@jonathannorris
jonathannorris added this pull request to the merge queue Oct 6, 2026
Merged via the queue into main with commit 1a55aeb Oct 6, 2026
10 checks passed
@jonathannorris
jonathannorris deleted the ci/svg-logo-lint branch October 6, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants