Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Honor
JSONCPP_WITH_INSTALL=OFFin the root CMake-package and pkg-config blocks, matching the existing library/header installation guards. Update the option help to describe all JsonCpp files, and add a configure/build regression job without changing the existing CI matrix or check names.The option was introduced in #1596 for submodule use. On current master, disabling it while leaving the default CMake-package option enabled fails generation:
If CMake packaging is also disabled, the current build can still install a
.pcfile for headers/libraries that were not installed. Both metadata formats describe an install tree, so they now follow the installation option as well. Their existing individual switches retain their behavior when installation is enabled.Testing
Local testing used Linux/GCC 14.2.0. Windows/macOS and hosted CI have not been run for this patch.