Skip to content

Add null guards 3 - #8913

Merged
jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:null-guard-applied-3
Oct 16, 2026
Merged

jack-berg merged 2 commits into
open-telemetry:mainfrom
jack-berg:null-guard-applied-3

Conversation

@jack-berg

Copy link
Copy Markdown
Member

Related to #8802.

See #8863 description for methodology.

  • io.opentelemetry.api.metrics.Meter
  • io.opentelemetry.api.metrics.MeterProvider
  • io.opentelemetry.api.trace.ArrayBasedTraceState
  • io.opentelemetry.api.trace.ArrayBasedTraceStateBuilder
  • io.opentelemetry.api.trace.DefaultTracer
  • io.opentelemetry.api.trace.DefaultTracerBuilder
  • io.opentelemetry.api.trace.DefaultTracerProvider
  • io.opentelemetry.api.trace.PropagatedSpan
  • io.opentelemetry.api.trace.SpanBuilder
  • io.opentelemetry.api.trace.SpanContext

- io.opentelemetry.api.metrics.Meter
- io.opentelemetry.api.metrics.MeterProvider
- io.opentelemetry.api.trace.ArrayBasedTraceState
- io.opentelemetry.api.trace.ArrayBasedTraceStateBuilder
- io.opentelemetry.api.trace.DefaultTracer
- io.opentelemetry.api.trace.DefaultTracerBuilder
- io.opentelemetry.api.trace.DefaultTracerProvider
- io.opentelemetry.api.trace.PropagatedSpan
- io.opentelemetry.api.trace.SpanBuilder
- io.opentelemetry.api.trace.SpanContext
@jack-berg
jack-berg requested a review from a team as a code owner October 7, 2026 19:36
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-16 20:26 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 18.62745% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.40%. Comparing base (45b9ed4) to head (831a65d).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
...ava/io/opentelemetry/api/trace/PropagatedSpan.java 11.11% 20 Missing and 20 partials ⚠️
...n/java/io/opentelemetry/api/trace/SpanContext.java 0.00% 16 Missing and 8 partials ⚠️
.../main/java/io/opentelemetry/api/metrics/Meter.java 0.00% 6 Missing ⚠️
...opentelemetry/api/trace/DefaultTracerProvider.java 0.00% 3 Missing and 3 partials ⚠️
.../opentelemetry/api/trace/DefaultTracerBuilder.java 0.00% 2 Missing and 2 partials ⚠️
...n/java/io/opentelemetry/api/trace/SpanBuilder.java 50.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (18.62%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8913      +/-   ##
============================================
- Coverage     90.55%   90.40%   -0.15%     
- Complexity    10702    10895     +193     
============================================
  Files          1007     1015       +8     
  Lines         29145    29841     +696     
  Branches       3760     3895     +135     
============================================
+ Hits          26392    26979     +587     
- Misses         1851     1910      +59     
- Partials        902      952      +50     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@breedx-splk breedx-splk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left a few comments before seeing the remark in the api-design.md, so that seems intentional after all.

@opentelemetry-pr-dashboard

This comment has been minimized.

@jack-berg
jack-berg merged commit b7be205 into open-telemetry:main Oct 16, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants