Skip to content

Treat declarative config max_request_size of 0 as no limit in OTLP exporters #8945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+48 −1
Open

Treat declarative config max_request_size of 0 as no limit in OTLP exporters #8945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../all/src/main/java/io/opentelemetry/exporter/otlp/internal/OtlpDeclarativeConfigUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ public static void configureOtlpExporterBuilder(

Integer maxRequestSize = config.getInt("max_request_size");
if (maxRequestSize != null) {
setMaxRequestSize.accept(maxRequestSize.longValue());
// The declarative config schema defines 0 as no limit
setMaxRequestSize.accept(maxRequestSize == 0 ? Long.MAX_VALUE : maxRequestSize.longValue());
}

DeclarativeConfigProperties tls =
Expand Down
16 changes: 16 additions & 0 deletions ...va/io/opentelemetry/sdk/autoconfigure/declarativeconfig/LogRecordExporterFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@ Stream<Arguments> createTestCases() {
.setMaxRequestBodySize(1234)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_http max_request_size 0",
new LogRecordExporterModel()
.setOtlpHttp(new OtlpHttpExporterModel().setMaxRequestSize(0)),
OtlpHttpLogRecordExporter.getDefault().toBuilder()
.setMaxRequestBodySize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc default",
new LogRecordExporterModel().setOtlpGrpc(new OtlpGrpcExporterModel()),
Expand Down Expand Up @@ -155,6 +163,14 @@ Stream<Arguments> createTestCases() {
.setMaxRequestMessageSize(1234)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc max_request_size 0",
new LogRecordExporterModel()
.setOtlpGrpc(new OtlpGrpcExporterModel().setMaxRequestSize(0)),
OtlpGrpcLogRecordExporter.getDefault().toBuilder()
.setMaxRequestMessageSize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_file/development",
LogRecordExporterModelAccessor.setOtlpFile(
Expand Down
16 changes: 16 additions & 0 deletions .../java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricExporterFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,14 @@ Stream<Arguments> createTestCases() {
Aggregation.base2ExponentialBucketHistogram()))
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_http max_request_size 0",
new PushMetricExporterModel()
.setOtlpHttp(new OtlpHttpMetricExporterModel().setMaxRequestSize(0)),
OtlpHttpMetricExporter.getDefault().toBuilder()
.setMaxRequestBodySize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc default",
new PushMetricExporterModel().setOtlpGrpc(new OtlpGrpcMetricExporterModel()),
Expand Down Expand Up @@ -181,6 +189,14 @@ Stream<Arguments> createTestCases() {
Aggregation.base2ExponentialBucketHistogram()))
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc max_request_size 0",
new PushMetricExporterModel()
.setOtlpGrpc(new OtlpGrpcMetricExporterModel().setMaxRequestSize(0)),
OtlpGrpcMetricExporter.getDefault().toBuilder()
.setMaxRequestMessageSize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"console",
new PushMetricExporterModel().setConsole(new ConsoleMetricExporterModel()),
Expand Down
14 changes: 14 additions & 0 deletions ...st/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/SpanExporterFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@ Stream<Arguments> createTestCases() {
.setMaxRequestBodySize(1234)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_http max_request_size 0",
new SpanExporterModel().setOtlpHttp(new OtlpHttpExporterModel().setMaxRequestSize(0)),
OtlpHttpSpanExporter.getDefault().toBuilder()
.setMaxRequestBodySize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc default",
new SpanExporterModel().setOtlpGrpc(new OtlpGrpcExporterModel()),
Expand Down Expand Up @@ -158,6 +165,13 @@ Stream<Arguments> createTestCases() {
.setMaxRequestMessageSize(1234)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"otlp_grpc max_request_size 0",
new SpanExporterModel().setOtlpGrpc(new OtlpGrpcExporterModel().setMaxRequestSize(0)),
OtlpGrpcSpanExporter.getDefault().toBuilder()
.setMaxRequestMessageSize(Long.MAX_VALUE)
.setComponentLoader(context)
.build()),
Arguments.argumentSet(
"console",
new SpanExporterModel().setConsole(new ConsoleExporterModel()),
Expand Down
Loading