Repository navigation
Upgrade build to use java 25 - #8949
Merged
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-16 14:00 UTC Status above doesn't look right?
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8949 +/- ##
============================================
+ Coverage 90.61% 90.66% +0.04%
- Complexity 10882 10889 +7
============================================
Files 1015 1015
Lines 29731 29736 +5
Branches 3876 3877 +1
============================================
+ Hits 26942 26959 +17
+ Misses 1872 1860 -12
Partials 917 917 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jaydeluca
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the build to use java 25 (latest LTS) instead of java 21.
There's a strange interaction between java 25 javac, the
--release 8configuration to build java 8 compatible jars, and theguava-beta-checkerwhich makes sure we don't use guava APIs annotated as beta in our source. Its annotation-name lookup triggers java 25 to resolve JSpecify's@NullMarkedannotation, including its@Target(MODULE)declaration. BecauseElementType.MODULEdoes not exist in the java 8 API view, javac emitswarning: unknown enum constant ElementType.MODULEwhich causes the build to fail because we set-Werror.The solution is to:
guava-beta-checker, since we eliminate the chance of accidentally using beta APIs and thus exposing users to errors at runtime when those APIs change