Skip to content

Fix consistent sampling corner cases - #8952

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
anuraaga:consistent-sampling-fixes
Oct 16, 2026
Merged

jack-berg merged 1 commit into
open-telemetry:mainfrom
anuraaga:consistent-sampling-fixes

Conversation

@anuraaga

Copy link
Copy Markdown
Contributor

When writing these, the spec was unclear on some parts which I misread/understood

  • The parent th vs rv consistench (rv<th) isn't validated. Not mandatory but not hard
  • Trace state updater needs to get the sampling decision
  • Dropped spans don't erase the parent ot as they are supposed to

@anuraaga
anuraaga requested a review from a team as a code owner October 16, 2026 04:47
@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-10-16 20:54 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (1522a4d) to head (3c50aa4).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8952   +/-   ##
=========================================
  Coverage     90.66%   90.66%           
- Complexity    10888    10893    +5     
=========================================
  Files          1015     1015           
  Lines         29736    29738    +2     
  Branches       3877     3878    +1     
=========================================
+ Hits          26959    26961    +2     
  Misses         1860     1860           
  Partials        917      917           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg
jack-berg merged commit b32298a into open-telemetry:main Oct 16, 2026
34 checks passed
@otelbot

otelbot Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @anuraaga! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants