Repository navigation
Fix consistent sampling corner cases - #8952
Merged
jack-berg merged 1 commit intoOct 16, 2026
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-10-16 20:54 UTC Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8952 +/- ##
=========================================
Coverage 90.66% 90.66%
- Complexity 10888 10893 +5
=========================================
Files 1015 1015
Lines 29736 29738 +2
Branches 3877 3878 +1
=========================================
+ Hits 26959 26961 +2
Misses 1860 1860
Partials 917 917 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Oct 16, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing these, the spec was unclear on some parts which I misread/understood
otas they are supposed to