Repository navigation
To remove cross module internal utility usage from trace propagators - #8955
NithinU2802 wants to merge 2 commits into
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-10-19 18:52 UTC Respond to 3 review items (e.g. link a commit, explain why not, ask a follow-up): Status above doesn't look right?
|
…ving only api internal utils
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8955 +/- ##
============================================
- Coverage 91.26% 90.41% -0.86%
- Complexity 10503 10911 +408
============================================
Files 1007 1017 +10
Lines 28373 29860 +1487
Branches 3586 3900 +314
============================================
+ Hits 25896 26998 +1102
- Misses 1685 1909 +224
- Partials 792 953 +161 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| * @param minLength the minimum length of the returned string | ||
| * @return the padded string, or {@code value} if it already meets the minimum length | ||
| */ | ||
| static String padLeft(String value, int minLength) { |
There was a problem hiding this comment.
I think this is only used in the opentelemetry-extension-trace-propagators module and tests, so let's go ahead and remove it from io.opentelemetry.api.internal.StringUtils.
| * @param string the string to check | ||
| * @return {@code true} if {@code string} is {@code null} or empty | ||
| */ | ||
| static boolean isNullOrEmpty(@Nullable String string) { |
There was a problem hiding this comment.
I think this method is kind of silly. Better to just enumerate the string == null || string.isEmpty() condition in the places that use it.
| * <p>This class is internal and is hence not for public use. Its APIs are unstable and can change | ||
| * at any time. | ||
| */ | ||
| final class TemporaryBuffers { |
There was a problem hiding this comment.
I think we should consider promoting this to a .impl. API since a second ThreadLocal increases the the allocation per thread when reuse is safe
This branch has not been deployed
2 participants
This PR is to resolves a part #6970 by updating the trace-propagators module’s dependency on API internal utility classes.
Changes
StringUtilsandTemporaryBuffersutilities.