Conversation
|
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-17 08:34 UTC Review the latest changes. Status above doesn't look right?
|
henry3260
left a comment
There was a problem hiding this comment.
Do we actually need to validate this? export_timeout_millis is stored in BatchProcessor but never read, and the log processor even has a comment saying "Not used. No way currently to pass timeout to export." So a non-positive value has no runtime effect today.
|
Thanks for taking a look @henry3260 I added validation mainly for consistency with That said, if we prefer not validating it until export timeouts are enforced in the export loop, happy to follow your lead! |
|
If we want to add validation here, we should add this too :) |
|
Added validation to |
Description
Fixes #5648
Currently,
BatchSpanProcessorvalidatesmax_queue_size,schedule_delay_millis, andmax_export_batch_sizeduring initialization to ensure they are positive integers. However,export_timeout_milliswas omitted from argument validation, allowing non-positive or negative values (0or negative integers) to be passed without error.This PR adds validation for
export_timeout_millisinBatchSpanProcessor._validate_arguments(), raising aValueErrorifexport_timeout_millis <= 0.Type of change
How Has This Been Tested?
opentelemetry-sdk/tests/trace/export/test_export.py(test_invalid_export_timeout_millis)Does This PR Require a Contrib Repo Change?
Checklist: