Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
All three JSON exporter paths silently discard configured TLS certificate settings.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds declarative configuration support for OTLP/HTTP JSON exporters across traces, metrics, and logs.
Changes:
- Selects protobuf or JSON exporters using
OtlpHttpEncoding. - Supports JSON exporter compression mapping and dependency errors.
- Adds configuration and factory tests plus a changelog entry.
File summaries
| File | Description |
|---|---|
.changelog/5669.added |
Records JSON exporter support. |
opentelemetry-configuration/src/opentelemetry/configuration/_common.py |
Supports uppercase compression enum members. |
opentelemetry-configuration/src/opentelemetry/configuration/_tracer_provider.py |
Adds JSON span exporter creation. |
opentelemetry-configuration/src/opentelemetry/configuration/_meter_provider.py |
Adds JSON metric exporter creation. |
opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py |
Adds JSON log exporter creation. |
opentelemetry-configuration/tests/test_common.py |
Tests uppercase compression mappings. |
opentelemetry-configuration/tests/file/test_loader.py |
Tests encoding enum conversion. |
opentelemetry-configuration/tests/test_tracer_provider.py |
Tests JSON span configuration. |
opentelemetry-configuration/tests/test_meter_provider.py |
Tests JSON metric configuration. |
opentelemetry-configuration/tests/test_logger_provider.py |
Tests JSON log configuration. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Pull request dashboard statusWaiting on maintainers · refreshed 2026-09-17 16:32 UTC Merge when ready. Status above doesn't look right?
|
lzchen
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support to
opentelemetry-configurationfor configuring OTLP JSON log, span and metric exporters.Fixes #5391
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: