Skip to content

test(sdk): fix flaky BatchProcessor shutdown test (#5663) #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 2 commits into from
Sep 21, 2026
Merged

test(sdk): fix flaky BatchProcessor shutdown test (#5663) #5675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b08a5
test(sdk): fix flaky BatchProcessor shutdown test (#5663)
Anurag-M1 Sep 18, 2026
498b09a
Merge branch 'main' into fix-5663-flaky-batch-processor-shutdown-test
herin049 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions opentelemetry-sdk/tests/shared_internal/test_batch_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,15 +274,16 @@ def test_shutdown_allows_1_export_to_finish(self, batch_processor_class, telemet
processor._batch_processor.emit(telemetry)
processor._batch_processor.emit(telemetry)
processor._batch_processor.emit(telemetry)
before = time.time()
before = time.monotonic()
processor._batch_processor.shutdown(timeout_millis=3000)
# Shutdown does not kill the thread.
assert processor._batch_processor._worker_thread.is_alive() is True

after = time.time()
after = time.monotonic()
assert after - before < 3.3
# Thread will naturally finish after a little bit.
time.sleep(0.1)

# The exporter shutdown interrupts the in-progress export. Depending
# on thread scheduling, the worker may stop before or shortly after
# shutdown() returns.
processor._batch_processor._worker_thread.join(timeout=1)
assert processor._batch_processor._worker_thread.is_alive() is False
# Expect the second call to be interrupted by shutdown, and the third call to never be made.
assert exporter.sleep_interrupted is True
Expand Down
Loading