Fix false results for whitespace-padded true responses - #3854
Merged
marcuswood-oai merged 2 commits intoSep 29, 2026
Merged
marcuswood-oai merged 2 commits into
marcuswood-oai merged 2 commits into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
marcuswood-oai
approved these changes
Sep 29, 2026
marcuswood-oai
enabled auto-merge
September 29, 2026 21:51
Contributor
Castiron custom code✅ No new custom-code files detected. 48 mixed files remain; 0 existing customizations changed. Compared 48 existing customizations unchanged
8 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 36636175731 --repo openai/openai-python \
--name castiron-custom-code-36636175731-1 --dir /tmp/castiron-custom-code-36636175731-1
git apply --stat /tmp/castiron-custom-code-36636175731-1/custom-code.patch
cat /tmp/castiron-custom-code-36636175731-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 49e4366847516621801ce3d82d7e47b7319c0873 0015fc6848bd217c30a60d64d91ab8678dc6d9d2
python3 scripts/castiron/custom_code_report.py report \
--base 49e4366847516621801ce3d82d7e47b7319c0873 \
--head 0015fc6848bd217c30a60d64d91ab8678dc6d9d2 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-0015fc6848bd
cat /tmp/castiron-custom-code-0015fc6848bd/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
A JSON
truewith a trailing newline is parsed asFalse. Both response parsers now trim whitespace and keep case-insensitive parsing.Additional context & links
true\n:Falsebefore,TrueafterReproducer and raw logs
Before:
After:
Both parser modules hit the same existing
AttributeError: module 'rich' has no attribute 'console'in the display helper before and after this change.