Repository navigation
feat(api): add cache settings and key options [2/2] - #4087
Merged
Merged
Conversation
Castiron-Internal-PR: openai/openai-python-internal#267 Castiron-Source-SHA: e748890d2046352bf289f1583e423d76880f453b Castiron-Public-Base-SHA: 9998c1a
Contributor
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 36 mixed files remain; 0 existing customizations changed; 4 customizations removed; 10 generated baselines changed. Compared
30 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38839055530 --repo openai/openai-python \
--name castiron-custom-code-38839055530-1 --dir /tmp/castiron-custom-code-38839055530-1
git apply --stat /tmp/castiron-custom-code-38839055530-1/custom-code.patch
cat /tmp/castiron-custom-code-38839055530-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9998c1a3806afda55cb3923de1f7f49adcff5a7f ecb5e394d83d28b74b3084bd2c5132e4f9912333
python3 scripts/castiron/custom_code_report.py report \
--base 9998c1a3806afda55cb3923de1f7f49adcff5a7f \
--head ecb5e394d83d28b74b3084bd2c5132e4f9912333 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-ecb5e394d83d
cat /tmp/castiron-custom-code-ecb5e394d83d/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
markstuart-oai
marked this pull request as ready for review
October 16, 2026 02:02
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
dpiet-oai
approved these changes
Oct 16, 2026
dpiet-oai
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Python users need optional cache controls for Decisions and independent scope or expiry updates for project keys.
High-level description
Add Decisions prompt-cache settings and text/image cache breakpoints. Allow project key scopes or expiry to be updated independently, and refresh model alias notices. Preserve existing WebSocket connection methods, defaults, credential handling, and API helpers.
Validation
CI passes, and all 236 consumer tests pass. Automated code and security reviews found no issues on the current head.
Existing WebSocket methods and signatures match the public baseline. Repeat generation produced identical files. An installed SDK generated with an unrelated WebSocket API passed eight real sync/async handshakes covering request hooks, credentials, events, reconnects, and cleanup, without changes to the SDK-owned runtime.