Repository navigation
feat(api): share Decisions cache breakpoint parameter type - #4092
Conversation
Castiron custom codeEvaluated main: Trusted main policy: Mixed files: 36 → 38 2 newly customized · 0 customizations removed · 0 existing customizations changed · 3 generated baselines changed Compared
35 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38967967675 --repo openai/openai-python \
--name castiron-custom-code-38967967675-1 --dir /tmp/castiron-custom-code-38967967675-1
git apply --stat /tmp/castiron-custom-code-38967967675-1/custom-code.patch
cat /tmp/castiron-custom-code-38967967675-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 6ea95a6d1f250840eda4cb99737a90fef31c7a14 b4ae04e5b1cab57e66bab02893b2aa6a80cfeefe
python3 scripts/castiron/custom_code_report.py report \
--base 6ea95a6d1f250840eda4cb99737a90fef31c7a14 \
--head b4ae04e5b1cab57e66bab02893b2aa6a80cfeefe --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b4ae04e5b1ca
cat /tmp/castiron-custom-code-b4ae04e5b1ca/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd201d7a6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed fd201d7a6a9d9c226ea755653b473e58da87760a. No actionable findings.
The shared breakpoint TypedDict accepts the same values as both legacy types. Preserving the existing classes and field annotations also preserves their runtime identity and import paths. I do not see a compatibility defect in that choice. The sync and async request tests cover explicit values, nulls, and omission.
The legacy checkpoint inventory fallback accepts only the audited checker digest; manifest ownership checks and the existing budget remain enforced. The trusted report accounts for the compatibility overlays rather than treating them as unmodified generated code.
Source review only. Hosted lint, build, Python 3.10/3.14, HTTPX2, baseline, and custom-code budget checks passed on this head. Candidate code was not executed locally.
Castiron-Internal-PR: openai/openai-python-internal#262 Castiron-Source-SHA: 885a3077d71810f12cb6f77ec421b0c6d4535403 Castiron-Public-Base-SHA: 6ea95a6
fd201d7 to
b4ae04e
Compare
Automated Release PR --- ## [3.33.0](openai/openai-python@v3.32.0...v3.33.0) (2026-10-16) ### Features * **api:** add safety identifiers to image requests and responses ([openai#4093](openai#4093)) ([c969e32](openai@c969e32)) * **api:** share Decisions cache breakpoint parameter type ([openai#4092](openai#4092)) ([f7cefda](openai@f7cefda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
2 participants
Summary
Reuse a shared prompt-cache breakpoint parameter type for Decisions text and image inputs.
Changes