Repository navigation
feat(api): add safety identifiers to image requests and responses - #4093
Conversation
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 38 mixed files remain; 0 existing customizations changed. Compared 38 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38972199066 --repo openai/openai-python \
--name castiron-custom-code-38972199066-1 --dir /tmp/castiron-custom-code-38972199066-1
git apply --stat /tmp/castiron-custom-code-38972199066-1/custom-code.patch
cat /tmp/castiron-custom-code-38972199066-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin f7cefdaf059a3e6856d49b4bc2e2e5fbdef8193b 73a42a8d560ec7e95f7efdbce35c372e7935e494
python3 scripts/castiron/custom_code_report.py report \
--base f7cefdaf059a3e6856d49b4bc2e2e5fbdef8193b \
--head 73a42a8d560ec7e95f7efdbce35c372e7935e494 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-73a42a8d560e
cat /tmp/castiron-custom-code-73a42a8d560e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
2c04b73 to
a918394
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed a918394b4361dde49354b71d6cce514fffa61848; no actionable findings.
Checked all 11 changed files, sync/async and streaming/non-streaming signatures and payload construction, plus the existing multipart and response-model helpers. The new argument is optional/keyword-only, user remains accepted, multipart None uses the existing omission behavior, and JSON generation can retain explicit null. Response fields and completed-event parsing are consistent with the schema; default to_dict() still excludes fields absent from the response.
The 24-case response/request regression matrix is useful, though it always sends a non-null request identifier. Static review only: I did not execute tests, builds, imports, or generation. All seven changed generated-file hashes match, git diff --check passed, and current-head hosted checks and Castiron statuses are successful or skipped.
Castiron-Internal-PR: openai/openai-python-internal#269 Castiron-Source-SHA: 418bdda09d1311d4a8053a245cdc78ba5364b6b1 Castiron-Public-Base-SHA: f7cefda
a918394 to
73a42a8
Compare
Automated Release PR --- ## [3.33.0](openai/openai-python@v3.32.0...v3.33.0) (2026-10-16) ### Features * **api:** add safety identifiers to image requests and responses ([openai#4093](openai#4093)) ([c969e32](openai@c969e32)) * **api:** share Decisions cache breakpoint parameter type ([openai#4092](openai#4092)) ([f7cefda](openai@f7cefda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
2 participants
Summary
Support safety identifiers when creating and editing images.
Changes
Testing
Validated 24 synchronous/asynchronous and streaming response cases. Eight deliberate value-loss controls failed as expected, and all 24 cases passed again after restoring the source. Current-head CI is running.