chore(install): remove dead OPENBOOT_VERSION pin from install.sh - #165
Merged
Conversation
VERSION and REPO were assigned at the top of scripts/install.sh and never read again: the script installs whatever the tap currently publishes via 'brew install openbootdotdev/tap/openboot', so OPENBOOT_VERSION had no effect. Drop both assignments and the AGENTS.md row that documented the variable as a working pin, so the env-var table matches what the script actually reads (OPENBOOT_DRY_RUN only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the dead
VERSION="${OPENBOOT_VERSION:-latest}"andREPO=...assignments fromscripts/install.sh, and theOPENBOOT_VERSIONrow from the env-var table inAGENTS.md.Why?
Both variables were assigned on lines 4–5 of
install.shand never read again — the script installs whatever the tap currently publishes viabrew install openbootdotdev/tap/openboot, so settingOPENBOOT_VERSIONsilently did nothing.AGENTS.mdstill documented it as "Pin version inscripts/install.sh", which is wrong. Found while auditing the openboot.dev docs against v1.0.0 (openbootdotdev/openboot.dev#35 drops the same row from the site's env-vars page).Testing
go vet ./...passesTestIntegration_InstallScript_ExistingInstallUpgradestill passes (go test ./test/integration/ -run InstallScript)bash -n scripts/install.shandOPENBOOT_DRY_RUN=true bash scripts/install.sh(prints the same "Would perform" plan as before)Cross-repo checklist
openboot.dev? — yes, already in docs: bring site copy in line with the v1.0.0 CLI openboot.dev#35 (removesOPENBOOT_VERSIONfrom/docs/env-vars)Notes for reviewer
Pure deletion, 3 lines. If a real version pin is wanted later it would have to go through Homebrew (versioned formulae in the tap); the old variable never wired into anything.