Skip to content

Yet more GHA issues - #1674

Merged
gregorydlogan merged 3 commits into
opencast:r/19.xfrom
gregorydlogan:t/yet-more-gha
Sep 23, 2026
Merged

gregorydlogan merged 3 commits into
opencast:r/19.xfrom
gregorydlogan:t/yet-more-gha

Conversation

@gregorydlogan

Copy link
Copy Markdown
Member

This PR does two GHA related things:

  • It removes incorrect checks in the pr publication workflow. These were checking the wrong thing, and failing. And not even required given that the workflow only fires on pull requests...
  • It fixes an error where the pull request number was set in the GHA environment, but not used when attempting to post the build complete comments

Both of these will need to be merged forward to develop prior to fixing the issue, but this is filed into r/19.x for sanity reasons.

@gregorydlogan gregorydlogan added type:bug Something isn't working type:github_actions Pull requests that update GitHub Actions code labels Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/ .
It might take a few minutes for it to become available.

… just the number since we need the full path for the comment made by the bot. PR number itself is now extracted from that build path
@gregorydlogan

Copy link
Copy Markdown
Member Author

The comment, once this is merged all the way forward, should work. This won't work correctly until then.

@gregorydlogan gregorydlogan self-assigned this Sep 23, 2026
@gregorydlogan
gregorydlogan merged commit f78b180 into opencast:r/19.x Sep 23, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working type:github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant