Repository navigation
fix: validate cipher blocks and derivation parameters - #1035
Merged
Merged
Conversation
andiwand
force-pushed
the
review/16-cfb-ownership
branch
from
October 4, 2026 21:11
acb9369 to
56ae165
Compare
The shared block check now throws for a partial last block. In a PDF, that error is not caught per object, so one damaged string stopped the whole document. Before, Crypto++ decrypted the whole blocks and left the partial block as zero bytes. The decryptor now passes only the whole blocks after the IV, so the out-of-bounds read stays fixed and the whole blocks still decrypt. The AES-V2 and AES-V3 paths share the helper. A crypto test also confirms that Blowfish CFB, a stream mode, accepts any length, because an ODF Blowfish stream has no block alignment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/17-crypto-blocks
branch
from
October 4, 2026 21:18
2728d90 to
44e177f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Malformed AES and Triple-DES input can reach Crypto++ release-mode block operations with incomplete blocks. Validate the mandatory block size in one shared processing helper, removing the duplicated wrappers. Reject PBKDF2 iteration counts and Argon2 lengths that would be truncated by their APIs.
Validation: 35 targeted crypto, PDF encryption, legacy Office encryption, and document-file tests pass, including partial-block rejection and known AES/PBKDF2 results.