Repository navigation
fix: preserve CSV records and bound cell coordinates - #1037
Merged
Merged
Conversation
andiwand
force-pushed
the
review/18-quantity-parsing
branch
from
October 5, 2026 05:58
2b39e8e to
28a6be0
Compare
andiwand
force-pushed
the
review/19-csv-boundaries
branch
from
October 5, 2026 06:05
6ed93b6 to
b12a6a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
CSV now treats bare carriage returns as record endings and preserves the first actual record delimiter when saving, excluding newlines inside quoted fields. Reapplying explicit options keeps Excel separator directives out of the data.
Reject coordinates and row/column growth that cannot fit the dimension or packed-ID representation before allocating or mutating cells. Invalid packed IDs no longer alias a lower row. Line-break quote characters are rejected as invalid dialects.
Validation: all 55 CSV tests pass. Existing parsing/save tests cover the delimiter fixes; one new regression checks coordinate aliasing, overflowing growth, and unchanged data after rejection.