Repository navigation
fix: retire removed XML element handles before freeing nodes - #1042
Merged
Merged
Conversation
andiwand
force-pushed
the
review/23-cfb-validation
branch
from
October 5, 2026 07:08
f7ae468 to
f5744fe
Compare
andiwand
force-pushed
the
review/24-removed-elements
branch
from
October 5, 2026 07:13
900def1 to
14bb998
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Retained handles could dereference freed XML nodes after explicit element removal or replacement of a cell's displayed text. Retire those IDs in the shared registry and validate payload access. Removing a document root now refuses before deleting its DOM nodes.
After the first retirement, lookups also check ancestors. This covers descendants and secondary element chains without adding a liveness field to every stored node; unedited documents keep the existing constant-time lookup path. Cell writers reuse the same invalidation helper.
Validation: 501 editing, ODF, OOXML, HTML, and recalculation tests pass. One cross-format regression checks retained descendant handles and refused root removal; existing cell-write tests now assert that replaced text handles are rejected.
Structural row/column deletion is being reviewed separately.