Repository navigation
fix: store the Word FIB prefix by value - #1052
Merged
Merged
Conversation
andiwand
force-pushed
the
review/33-ppt-record-bounds
branch
from
October 5, 2026 08:45
e8d8950 to
856d022
Compare
The surplus fibRgW and fibRgLw entries and the grpprl of a Prc were skipped with an unchecked ignore. A stream that ends inside them continued at the wrong position. byte_stream::skip throws there, the same as a short read. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/34-doc-fib-storage
branch
from
October 5, 2026 08:59
653bedc to
aa33203
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Legacy Word allocated version-specific FIB structures and deleted them through non-virtual base pointers. The parser now stores the common prefix by value and drops the unused extended layouts. Counted extension data is bounded before reading its version-specific fields, and invalid FIB signatures are rejected.
The common prefix contains every offset currently consumed by the engine, so this removes unsafe ownership and unused structures while preserving newer-version support.
Validation: 12 Word/encryption tests and 17 DOC corpus cases pass; the encrypted corpus case remains skipped. One synthetic test covers supported extension versions, future base versions, surplus offset entries, truncated declared extensions, signatures, and negative body lengths.