Repository navigation
fix: report legacy decodability and reuse format metadata - #1055
Merged
Merged
Conversation
andiwand
force-pushed
the
review/36-xls-record-validation
branch
from
October 5, 2026 09:26
ad4a373 to
916f8c4
Compare
The encryption check before parsing again says why it must come first. The stream table again says that each format must have its stream. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/37-legacy-metadata
branch
from
October 5, 2026 09:53
f6a86bf to
1a5830a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Unencrypted legacy Office files now report themselves as decodable. Their MIME and document types come from the shared file-type table, removing a second metadata table and giving stream detection a stable order.
XLS style resolution no longer retains raw Font records after copying their names into resolved styles. Ownership comments now match the string-valued style API.
Validation: all 34 legacy Office and encryption tests pass. Existing format and encryption tests now check decodability; no additional test fixtures were introduced.