Repository navigation
fix(odf): parse bounded decimal tokens independently of locale - #1085
Merged
Merged
Conversation
andiwand
force-pushed
the
review/66-odf-geometry-bounds
branch
from
October 5, 2026 18:27
3de9f70 to
68a1cc2
Compare
Each test file now includes its own header first, so a missing include in that header still shows. The geometry test includes clocale for setlocale. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/67-odf-number-tokens
branch
from
October 5, 2026 18:32
8d62f54 to
309c283
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
ODF geometry numbers now use a decimal-token scanner and the existing locale-independent number parser. Decimal points work under a comma-decimal host locale, overflow is rejected, and reading a number no longer copies the remaining arithmetic expression. Adjacent signed numbers and incomplete exponents retain their token boundaries.
Two focused regressions cover locale behavior and token boundaries. Four existing tests now share a locale-restoration guard with the new test, avoiding another duplicate helper. All 93 geometry, quantity, font, and XLS checks pass; no locale tests were skipped.