Repository navigation
fix: escape document locale and preserve named views - #1092
Merged
Merged
Conversation
andiwand
force-pushed
the
review/73-archive-resources
branch
from
October 5, 2026 19:37
1b166db to
47877f1
Compare
The check for a text document does not depend on the fragment, so it moves out of the loop. Drop the extra parentheses in the locale test. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/74-document-html-metadata
branch
from
October 5, 2026 19:42
4bb8cb4 to
0327f15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Escape locale metadata before writing HTML attributes, and preserve individual sheet, slide and page views when their name is
document. Previously that name was mistaken for the combined document view.Validation: 127 HTML, URI and document-style checks pass. Extends the existing locale test and adds one sheet-view regression.