Repository navigation
fix(jni): release handles and arrays on allocation failures - #1100
Merged
Merged
Conversation
andiwand
force-pushed
the
review/81-jni-integer-bounds
branch
from
October 5, 2026 20:32
308873c to
afc3a6e
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
andiwand
force-pushed
the
review/82-jni-allocation-cleanup
branch
from
October 5, 2026 20:34
19e69f9 to
413414f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
JNI handle construction now keeps ownership until its tracking vector accepts the handle, preventing a leak when that allocation fails. Decode priorities and selected HTML views use array-region copies instead of pins that could survive C++ exceptions. Array lengths are checked before narrowing to JNI sizes, and logger setup stops after failed reference/method allocation.
Validation: all 81 JNI tests pass. Extended existing decode-option and selected-view export tests; no additional test cases. A temporary allocation-failure harness reproduces the handle leak on the parent revision and passes after the fix.