Repository navigation
fix(http): keep shutdown independent of logging callbacks - #1143
Merged
Merged
Conversation
andiwand
force-pushed
the
review/124-explicit-reader-invariants
branch
from
October 6, 2026 13:19
717f6ba to
c60c215
Compare
andiwand
force-pushed
the
review/125-http-cleanup-logging
branch
from
October 6, 2026 13:27
c29bd7f to
f4f8188
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
HTTP shutdown invoked user logging callbacks before stopping the server and again while clearing services. A throwing logger could interrupt
stop()and terminate the process when the final handle was destroyed. Keep shutdown independent of logging and clear services under the existing lifecycle lock after listeners return.Validation: the new throwing-logger regression fails and terminates on the parent revision; all 12 HTTP server tests pass with loopback access. Targeted LLVM 22 clang-tidy passes with the unrelated inheritance checks excluded.