Repository navigation
fix(pdf): validate the complete AES padding trailer - #1145
Merged
Merged
Conversation
andiwand
force-pushed
the
review/126-analysis-policy
branch
from
October 6, 2026 14:04
9ff0b9f to
22862fd
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/127-pdf-aes-padding
branch
from
October 6, 2026 14:31
1a2b4f4 to
ab3e889
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
PDF AES decryption removed a trailer based only on its final byte, truncating plaintext when preceding padding bytes disagreed. Check the complete padding before stripping it and retain the existing lenient behavior for malformed trailers. Use fixed-width counters throughout the password algorithms.
Validation: the new regression fails on the parent for malformed padding lengths 2–16 and passes after the fix; all 79 encryption, parser and PDF-file tests pass. LLVM 22 clang-tidy passes.