Repository navigation
fix: validate PDF cross-reference targets before caching objects - #1153
Merged
Merged
Conversation
andiwand
force-pushed
the
review/134-pdf-xref-generations
branch
from
October 6, 2026 17:39
5d50960 to
2d08dc0
Compare
andiwand
force-pushed
the
review/135-pdf-reference-validation
branch
from
October 6, 2026 17:49
5c7ed52 to
30cea86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Malformed PDF cross-references could return an indirect object with another ID or generation, or the wrong member of an object stream. Failed stream state also prevented subsequent seeks, including reads from cached stream objects.
Validate indirect and compressed object identities before caching the result, and clear stream state before object and payload seeks. Parser API comments now state the ownership/lifetime contract concisely; cache rationale lives in the module guide.
Validation: all three regression tests fail on the parent; 83 focused parser, writer, annotation and public PDF tests pass. All 50 PDF corpus metadata/HTML-generation cases pass (no visual comparison). LLVM 22 clang-tidy passes.